WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #40807, comment 5


Ignore:
Timestamp:
10/06/2017 06:39:46 PM (7 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #40807, comment 5

    initial v1  
    11@birgire patch is looking good! I don't think we need to worry about restricting which post types can have children. I think this `hierarchical` property is really more for the sake of the UI than a restriction on the data model. After all, an `attachment` post can have parent even though it isn't hierarchical.
    22
    3 See my [https://github.com/xwp/wordpress-develop/pull/276/commits/0bfc4dc changes] for what needed to be done to apply [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards WordPress-Coding-Standards].
     3See my [https://github.com/xwp/wordpress-develop/pull/276/commits/0bfc4dc changes] for what needed to be done to apply [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards WordPress-Coding-Standards]. It was mostly whitespace changes; see [https://github.com/xwp/wordpress-develop/pull/276/commits/0bfc4dc117e93c9e2365337e38b36864768ae055?w=1 diff without].
    44
    55A build is running now: https://travis-ci.org/xwp/wordpress-develop/builds/284338738