WordPress.org

Make WordPress Core

Changes between Initial Version and Version 4 of Ticket #40810


Ignore:
Timestamp:
07/29/2017 08:55:01 PM (2 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40810

    • Property Keywords has-patch has-unit-tests added
  • Ticket #40810 – Description

    initial v4  
    33On some of our WordPress instances wp-cron.php is called by system cron directly as a parameter to php command ( not via HTTP request ). This is partially to make sure that WP cron is executed regularly and partially to make sure that all tasks in cron will not hit a timeout for HTTP communication on servers and reverse proxies.
    44
    5 In a case when WP triggers auto update during such php execution and wants to send email about success, there is no $_SERVER['SERVER_NAME'] available and no From: header passed to wp_mail, therefore sender's email is not fully generated and delivery fails:
     5In a case when WP triggers auto update during such php execution and wants to send email about success, there is no `$_SERVER['SERVER_NAME']` available and no From: header passed to wp_mail, therefore sender's email is not fully generated and delivery fails:
     6{{{
    67PHP Fatal error:  Uncaught exception 'phpmailerException' with message 'Invalid address:  (setFrom) wordpress@'
     8}}}
    79
    810There are at least three possible solutions which could generate valid email address and maybe help in more scenarios too:
    911
    10121) WP auto update fix
    11 As WP update knows what is the site URL of WP during update, it could construct sender's email directly from configuration, pass it as From: header to wp_mail and not need to rely on whether SERVER_NAME is set or not.
     13As WP update knows what is the site URL of WP during update, it could construct sender's email directly from configuration, pass it as From: header to wp_mail and not need to rely on whether `SERVER_NAME` is set or not.
    1214
    13152) Local hostname fix
    14 When wp_mail is called and From: header is not present, wp_mail tries to construct the sender's email from SERVER_NAME. In case neither SERVER_NAME is available, wp_mail could try to call function like php_uname or gethostname yet as a last resort for construction of sender's email. This could ( at least to some extent ) help with such wp_mail calls where SERVER_NAME is not available.
     16When wp_mail is called and From: header is not present, wp_mail tries to construct the sender's email from `SERVER_NAME`. In case neither `SERVER_NAME` is available, wp_mail could try to call function like `php_uname` or `gethostname` yet as a last resort for construction of sender's email. This could ( at least to some extent ) help with such wp_mail calls where `SERVER_NAME` is not available.
    1517
    16183) Sender's email configuration option
    17 By providing possibility to have a default sender's email for WP configured, it would be possible to use such address as sender in wp_mail function and rely on SERVER_NAME only if configuration option would be not set ( or set empty ). Based on history of tickets related to sender's email address, this fix would help many users for which current construction of sender's address is not suitable and work also in backward compatible way.
     19By providing possibility to have a default sender's email for WP configured, it would be possible to use such address as sender in wp_mail function and rely on `SERVER_NAME` only if configuration option would be not set ( or set empty ). Based on history of tickets related to sender's email address, this fix would help many users for which current construction of sender's address is not suitable and work also in backward compatible way.
    1820
    1921Do you see any of these options acceptable?