Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#40814 closed enhancement (fixed)

Order of page title parts

Reported by: henrywright's profile henry.wright Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch good-first-bug needs-testing
Focuses: Cc:

Description

The order of page title parts in wp-login.php is inconsistent with the rest of the site pages.

For example, in wp-login.php we have this arrangement:

Sitename Separator Pagename

For the rest of the site we have this arrangement:

Pagename Separator Sitename

I suggest we modify the order of the page title parts in wp-login.php to match page titles elsewhere.

Attachments (1)

40814.patch (552 bytes) - added by nishitlangaliya 8 years ago.
Fixed issue - 40814

Download all attachments as: .zip

Change History (14)

@nishitlangaliya
8 years ago

Fixed issue - 40814

This ticket was mentioned in Slack in #core by nishitlangaliya. View the logs.


8 years ago

#2 @welcher
8 years ago

  • Keywords has-patch good-first-bug added

#3 @SergeyBiryukov
8 years ago

  • Component changed from General to Login and Registration
  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 follow-up: @henry.wright
8 years ago

Related is #40812. The page title separator character used in wp-login.php is inconsistent with the separator used in page titles elsewhere.

Depending on is_rtl(), wp-login.php will use either the › or ‹ characters whereas the rest of the site uses a hyphen (although the hyphen may possibly be an –).

Last edited 8 years ago by SergeyBiryukov (previous) (diff)

#5 in reply to: ↑ 4 @nishitlangaliya
8 years ago

Hi @henry.wright ,

I have added patch to ticket please check for the same and let me know any changes required.

Replying to henry.wright:

Related is #40812. The page title separator character used in wp-login.php is inconsistent with the separator used in page titles elsewhere.

Depending on is_rtl(), wp-login.php will use either the › or ‹ characters whereas the rest of the site uses a hyphen (although the hyphen may possibly be an –).

This ticket was mentioned in Slack in #core by nishitlangaliya. View the logs.


8 years ago

This ticket was mentioned in Slack in #core by nishitlangaliya. View the logs.


8 years ago

#8 @jbpaul17
7 years ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 years ago

#11 @SergeyBiryukov
7 years ago

  • Milestone changed from 4.9 to Future Release

#12 @SergeyBiryukov
7 years ago

  • Milestone changed from Future Release to 4.9

On second thought, this can go in to make the title consistent with other pages until is #40812 fixed.

#13 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41690:

Login and Registration: Make the order of <title> tag parts on login page consistent with the rest of admin pages.

Props nishitlangaliya, henry.wright.
Fixes #40814.

Note: See TracTickets for help on using tickets.