WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

#40840 closed defect (bug) (fixed)

Missing @deprecated tag for WP_Admin_Bar::recursive_render()

Reported by: coffee2code Owned by: DrewAPicture
Milestone: 4.9 Priority: normal
Severity: trivial Version:
Component: General Keywords: has-patch
Focuses: docs Cc:

Description

WP_Admin_Bar::recursive_render() in wp-includes/class-wp-admin-bar.php was deprecated in v3.3 via [19501] but a @deprecated phpdoc tag was not added. Attached is a patch that adds it.

Attachments (2)

40840.diff (574 bytes) - added by coffee2code 7 months ago.
Adds missing @deprecated tag
40840.2.diff (498 bytes) - added by coffee2code 7 months ago.
Adds missing @deprecated and @see tags (and puts them above @param tags)

Download all attachments as: .zip

Change History (6)

@coffee2code
7 months ago

Adds missing @deprecated tag

#1 @swissspidy
7 months ago

Thanks for the patch!

According to the inline documentation standards we also add a @see annotation for deprecated functions/methods.

@coffee2code
7 months ago

Adds missing @deprecated and @see tags (and puts them above @param tags)

#2 @coffee2code
7 months ago

According to the inline documentation standards we also add a @see annotation for deprecated functions/methods.

Patch updated to add @see tags and to move patched additions before the @param tags.

#3 @DrewAPicture
6 months ago

  • Milestone changed from Awaiting Review to 4.9

Thanks Scott!

#4 @DrewAPicture
6 months ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 40947:

Docs: Add missing deprecation, introduction, and summary information to the DocBlock for WP_Admin_Bar::recursive_render().

Props coffee2code.
Fixes #40840.

Note: See TracTickets for help on using tickets.