WP_Query->have_posts() -- add action if no results are found

[mgibbs189]

We can hook into loop_start and loop_end when results are found, but there's no loop_no_results hook. This patch adds that!

[mgibbs189]

class-wp-query.php patch

[mgibbs189]

@SergeyBiryukov @swissspidy Howdy, could I please get dev feedback on this one?

We're doing template auto-detection for FacetWP, and this loop_no_results action will allow us to "latch on" to the template when no results are found... which isn't currently possible via loop_start or loop_end.

[boonebgorges]

Hi @mgibbs189 - Sorry for the delay in reviewing the patch.

Adding an action here seems like a fine idea, and your technique for firing the action - in an elseif ( 0 === $this->post_count ) clause - seems like the most efficient way to do it.

A couple small requests on the patch:

• The @since annotation needs updating for 4.9, and we generally use the three-digit format: @since 4.9.0. See ​https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#since-section-changelogs
• The use of do_action_ref_array( ..., array( &$this ) ) is a legacy of PHP4 support. do_action( ..., $this ) should be sufficient - the object ought to be passed by reference automatically.

Thanks!

[mgibbs189]

@boonebgorges Great feedback, thank you. I've attached an updated patch. Please let me know if it looks OK.

[boonebgorges]

[40923] missed the ticket.