WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 4 weeks ago

#40857 closed defect (bug) (fixed)

Display issue of plugin searchbar in 4.8 beta 2

Reported by: Guido07111975 Owned by: adamsilverstein
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.8
Component: Plugins Keywords: has-screenshots commit has-patch
Focuses: administration Cc:

Description

Hi members of core tean,

In 4.8 beta (version 2) the plugin searchbar in dashboard isn't displayed properly. Check attachment.

Guido

Attachments (3)

plugin-searchbar.jpg (140.0 KB) - added by Guido07111975 4 weeks ago.
Plugin searchbar in 4.8 beta 2
40857.diff (511 bytes) - added by juhise 4 weeks ago.
Patch
40857.2.diff (391 bytes) - added by voldemortensen 4 weeks ago.

Download all attachments as: .zip

Change History (11)

@Guido07111975
4 weeks ago

Plugin searchbar in 4.8 beta 2

#1 @johnbillion
4 weeks ago

  • Focuses administration added
  • Keywords has-screenshots needs-testing added
  • Milestone changed from Awaiting Review to 4.8

#2 @leemon
4 weeks ago

In 4.7:

.wp-filter .search-form input[type="search"] {
    ...
    width: 280px;
    ...
}

In 4.8:

.wp-filter .search-form input[type="search"] {
    ...
    width: 100%;
    ...
}

@juhise
4 weeks ago

Patch

#3 @juhise
4 weeks ago

This patch seems to solve this issue, tested at other places, not effecting anything else.

#4 @voldemortensen
4 weeks ago

This change was made in https://core.trac.wordpress.org/changeset/30813. "Fix the search field width in the media modal, media library grid and on the install new plugins screen."

Those screens should be tested.

#5 @voldemortensen
4 weeks ago

  • Keywords commit added; needs-testing removed

50857.2.diff is the same patch, but with the file path changed for easier committing. I've tested the screens mentioned in the previous changeset and everything look great.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


4 weeks ago

#7 @jbpaul17
4 weeks ago

  • Keywords has-patch added

#8 @adamsilverstein
4 weeks ago

  • Owner set to adamsilverstein
  • Resolution set to fixed
  • Status changed from new to closed

In 40840:

Plugins: fix regression in search input field size.

Fix a formatting regression introduced in [40792] which attempted to resize the input for mobile, see #40130.

Props leemon, juhise, voldemortensen.
Fixes #40857.

Note: See TracTickets for help on using tickets.