WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#40864 new enhancement

Standardize strings for missing attachments across media widgets

Reported by: dimadin Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.8
Component: Widgets Keywords:
Focuses: Cc:
PR Number:

Description

While translating 4.8 strings, I noticed that strings for missing attachments in the new media widgets do not refer to the same thing:

We can&#8217;t find that audio file. Check your <a href="%s">media library</a> and make sure it wasn&#8217;t deleted.

We can&#8217;t find that image. Check your <a href="%s">media library</a> and make sure it wasn&#8217;t deleted.

We can&#8217;t find that video. Check your <a href="%s">media library</a> and make sure it wasn&#8217;t deleted.

We can&#8217;t find that file. Check your <a href="%s">media library</a> and make sure it wasn&#8217;t deleted.

In two occasions we only use media type, but once we use "file" alongside of it and once we only use "file" and remove any mention of media (type).

I propose removing "file" completely and just using type of media. Second possibility is to always use "file", though I don't see that as needed.

Attachments (1)

40864.diff (1.6 KB) - added by dimadin 3 years ago.

Download all attachments as: .zip

Change History (3)

@dimadin
3 years ago

#1 @karmatosed
3 years ago

  • Component changed from General to Widgets

#2 @westonruter
3 years ago

@dimadin the reason for “audio file” is that according to my English ears, audio isn't a count noun, unlike images and videos. It sounds strange to talk about “an audio”. See https://english.stackexchange.com/questions/40429/if-i-can-say-videos-may-i-also-say-audios

Note: See TracTickets for help on using tickets.