Strings for city search in community events widget need improvement

[dimadin]

Two strings for new community events widgets use American cities that should be replaced with cities in places where that particular language is used. I think that it's not clear enough in translators comments that they should be replaced, not translated. Also, one comment is less descriptive than the other one and even less clear.

Another, more important thing is that context is not used for "Cincinnati" even though we don't want its translation but name of other local city.

[iandunn]

These changes sound good to me.

I wonder if we should also add something like this:

...that shows events (test that it matches the expected location before including it). If no cities related to your locale have events, then use cities related to your locale that would be recognizable to most users.

Without that, I'd worry that some translators might just leave the American cities in place when there aren't any cities related to their locale that have events.

[dimadin]

That is good addition, it wouldn't hurt to have that too.

[iandunn]

Add instructions for situations when no cities have events

[ocean90]

I don't see the need for adding a context to the Cincinnati string here. The context function should only be used to distinguish the same string in different contexts like verb/noun. That's not really the case here.

Changing translator comments is fine since it doesn't invalidate existing translations.

[kirasong]

+1 with @ocean90's suggested change.

[iandunn]

removes use of esc_attr_x(), tweaks language

[iandunn]

Thanks for pointing that out. 40865.3.diff​ removes the esc_attr_x() call, and tweaks the language so that both comments are consistent with each other.

[ocean90]

In 40866:

I18N: Improve translator comments for strings in the community events widget.

Props dimadin, iandunn.
Fixes #40865.