WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 months ago

Last modified 2 months ago

#40883 closed enhancement (fixed)

update getid3 to 1.9.14

Reported by: jkitchen Owned by: jorbin
Milestone: Priority: normal
Severity: normal Version: 4.8
Component: Media Keywords:
Focuses: Cc:
PR Number:

Description

Greetings!

I'd like to make some changes to extract geolocation information from MOV files created by and uploaded from iPhones, and there's an update to the getid3 library to do just that.

https://github.com/JamesHeinrich/getID3/compare/v1.9.9...v1.9.14

The update I'm after was shipped in v1.9.11:

https://github.com/JamesHeinrich/getID3/commit/a1e96a82d95dffb9ab63009464e8326614dc2373

https://github.com/JamesHeinrich/getID3/compare/v1.9.9...v1.9.11

However, may as well upgrade all the way to 1.9.14? Let me know if there's anything I can do to help make this happen!

Attachments (1)

getid3-1.9.9...1.9.14.patch (249.6 KB) - added by jkitchen 2 years ago.
diff of copied files from 1.9.14 into wordpress source

Download all attachments as: .zip

Change History (6)

@jkitchen
2 years ago

diff of copied files from 1.9.14 into wordpress source

#1 @jkitchen
2 years ago

I ran the phpunit tests against this code and got:

OK, but incomplete, skipped, or risky tests!
Tests: 7926, Assertions: 33746, Skipped: 40, Risky: 24.

This is on PHP 7.0.19 against MariaDB 10.1.19 on my laptop.

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


10 months ago

#3 @joemcgill
10 months ago

  • Milestone changed from Awaiting Review to Future Release

Thanks @jkitchen. Sorry for the long wait for a reply here. Updating this library makes sense to me, but we should probably go ahead and bump to the latest release, which is currently 1.9.16. If you or someone else wants to put together another patch, we can likely get this in soon.

Also, it would be helpful to know if any of the files included in trunk have been edited from the 1.9.9 source.

#4 @desrosj
2 months ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

While not directly a duplicate, #47751 (more specifically [46112]) has updated the getID3 library to the latest version (now 1.9.18) in order to fix some PHP 7.4 compatibility issues. This can be closed out in favor of that ticket.

@jkitchen Thanks for your initial patch on this!

#5 @jorbin
2 months ago

  • Owner set to jorbin
  • Resolution changed from duplicate to fixed

In 46166:

External Library: Update getid3 to 1.9.18

Follow up to r46112 as getid3 has tagged an official release.

Changes: https://github.com/JamesHeinrich/getID3/compare/00f3fbfd77e583099ca70a3cf0bc092e113d2b20...v1.9.18

Props desrosj, jkitchen.
Fixes #47751 #40883 #43836.

Note: See TracTickets for help on using tickets.