WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#40893 closed defect (bug) (fixed)

TinyMCE: prevent warnings about missing stylesheets

Reported by: azaozz Owned by: azaozz
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.8
Component: TinyMCE Keywords: has-patch commit
Focuses: Cc:

Description

It appears that some themes still try to load fonts from Google where the URLs have unencoded commas. That breaks this functionality in TinyMCE as it splits multiple URLs on commas and tries to load the fragments.

The difference is that the latest TinyMCE shows warnings in the UI when a stylesheet fails to load.

Attachments (2)

40893.patch (621 bytes) - added by azaozz 5 months ago.
warning.png (3.7 KB) - added by ocean90 5 months ago.
Screenshot of the warning, props @azaozz

Download all attachments as: .zip

Change History (6)

@azaozz
5 months ago

#1 @azaozz
5 months ago

In 40893.patch: force the urlencoding of commas in the URLs that are passed to the content_css TinyMCE setting.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


5 months ago

@ocean90
5 months ago

Screenshot of the warning, props @azaozz

#3 @ocean90
5 months ago

  • Keywords has-patch commit added

+1 for 40893.patch, after changing $editor_styles[$key] to $editor_styles[ $key ] and adding a full stop to the comment.

#4 @azaozz
5 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 40862:

TinyMCE: Force urlencoding of commas in URLs added by plugins to prevent warnings about missing stylesheets.

Fixes #40893.

Note: See TracTickets for help on using tickets.