Opened 8 years ago
Closed 8 years ago
#40895 closed defect (bug) (fixed)
Unwanted indentation in sample page content
Reported by: | swissspidy | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 4.7.4 |
Component: | Networks and Sites | Keywords: | has-patch commit |
Focuses: | multisite | Cc: |
Attachments (1)
Change History (7)
#2
@
8 years ago
- Component changed from General to Networks and Sites
- Focuses multisite added
@ocean90 @SergeyBiryukov Mind reviewing this patch? Thanks!
#3
follow-up:
↓ 4
@
8 years ago
The problem was that this string was recently changed, this indentation was added, breaking the existing translation. Luckilly it was just marked as fuzzy and it was easy to spot the differences. Still, this change was unnecessary.
To avoid this in the future, strings like this should be parted out in several complete sentences, giving developers complete freedom to change its appearance without breaking any current translations,
#4
in reply to:
↑ 3
@
8 years ago
- Keywords commit added
Replying to pedromendonca:
To avoid this in the future, strings like this should be parted out in several complete sentences, giving developers complete freedom to change its appearance without breaking any current translations,
I think it's easier to translate content like this as a single string (pretty much like email templates) to avoid losing context between sentences, we just have to be careful not to add any unnecessary whitespace :)
40895.diff looks good.
Well done! :)