WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#40905 closed task (blessed) (fixed)

Prepare bundled themes for 4.8

Reported by: ocean90 Owned by: davidakennedy
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.8
Component: Bundled Theme Keywords: good-first-bug has-patch
Focuses: Cc:
PR Number:

Description

Attachments (4)

40905.patch (5.6 KB) - added by maedahbatool 2 years ago.
Default Themes: Bump version numbers and update readme files.
40905.2.patch (7.2 KB) - added by mrahmadawais 2 years ago.
Default Themes: Bump version numbers and update readme files. Add Changelog for new versions!
40905.3.patch (7.2 KB) - added by mrahmadawais 2 years ago.
Default Themes: Bump version numbers and update readme files. Add Changelog for new versions! Dates fixed!
40905.4.patch (16.7 KB) - added by davidakennedy 2 years ago.
Change version numbers in stylesheets, fix typo in Twenty Fourteen readme and update copyright dates for themes.

Download all attachments as: .zip

Change History (21)

#1 @ocean90
2 years ago

  • Keywords good-first-bug added

@maedahbatool
2 years ago

Default Themes: Bump version numbers and update readme files.

#2 @maedahbatool
2 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

Hey, guys!
This is my first core attempt at core contribution. Go easy on me 🙌

I update the theme versions where required. Changelog needs to be added. Since I am not sure how to create that on codex pages. I am adding changelog here.

TwentySeventeen Changelog

  • Improve styles for 4.8 widgets
  • Remove unnecessary return statement

TwentySixteen Changelog

  • No changes

TwentyFifteen Changelog

  • Improve styles for 4.8 widgets

TwentyFourteen Changelog

  • Improve styles for 4.8 widgets

TwentyThirteen Changelog

  • Improve styles for 4.8 widgets

TwentyTwelve Changelog

  • Improve styles for 4.8 widgets

TwentyEleven Changelog

  • Improve styles for 4.8 widgets

TwentyTen Changelog

  • Improve styles for 4.8 widgets
  • Introduce media widgets for images, audio, and video with extensible base for additional media widgets in the future.

Let me know how I did :). Excited to get my first prop :)

@mrahmadawais
2 years ago

Default Themes: Bump version numbers and update readme files. Add Changelog for new versions!

#3 @mrahmadawais
2 years ago

@ocean90 Following @maedahbatool 's patch, I went ahead and added the changelogs in the readme.txt files as well as updated the relevant codex pages with the actual changelog along with the trac ticket links.

Kindly, take a look at it, I think next steps are for a release lead.

Looking forward!

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#5 @jbpaul17
2 years ago

  • Owner set to davidakennedy
  • Status changed from new to assigned

#6 follow-up: @ocean90
2 years ago

  • Keywords dev-feedback removed

@mrahmadawais @mrahmadawais Thanks for the Codex updates and the patches. Just one thing: The release is on June 8.

#7 in reply to: ↑ 6 @mrahmadawais
2 years ago

Replying to ocean90:

@mrahmadawais @mrahmadawais Thanks for the Codex updates and the patches. Just one thing: The release is on June 8.

Oh, I thought it was a day late. June 8, 2017 (+1d)

I will update everything! And will create a new patch.

@mrahmadawais
2 years ago

Default Themes: Bump version numbers and update readme files. Add Changelog for new versions! Dates fixed!

#8 @mrahmadawais
2 years ago

@ocean90 @maedahbatool I have updated the codex pages and added a new patch. Take a look.

#9 @davidakennedy
2 years ago

#40943 was marked as a duplicate.

#10 follow-ups: @davidakennedy
2 years ago

Good work @maedahbatool and @mrahmadawais! Made a few small tweaks. Stylesheets need updated version numbers too. It's always a good time to check copyright dates on the themes, and I also fixed a typo.

@davidakennedy
2 years ago

Change version numbers in stylesheets, fix typo in Twenty Fourteen readme and update copyright dates for themes.

This ticket was mentioned in Slack in #core by davidakennedy. View the logs.


2 years ago

#12 @jorbin
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40883:

Bundled Themes - Bump themes in preparation for 4.8

Change version numbers in stylesheets, fix typo in Twenty Fourteen readme and update copyright dates for themes. Twentysixteen wasn't updated this cycle.

See #40745 for changes that helped push this along.
Fixes #40905.
Props davidakennedy, mrahmadawais, maedahbatool.

#13 @jorbin
2 years ago

In 40884:

Bundled Themes - Bump themes in preparation for 4.8

Backports [40883] from trunk to 4.8

Change version numbers in stylesheets, fix typo in Twenty Fourteen readme and update copyright dates for themes. Twentysixteen wasn't updated this cycle.

See #40745 for changes that helped push this along.
Fixes #40905.
Props davidakennedy, mrahmadawais, maedahbatool.

#14 in reply to: ↑ 10 @mrahmadawais
2 years ago

Replying to davidakennedy:

Good work @maedahbatool and @mrahmadawais!

Thanks 🤗 | @maedahbatool Congrats on your first contribution!

Made a few small tweaks. Stylesheets need to be updated version numbers too.

Dang it, how'd I missed that :P

It's always a good time to check copyright dates on the themes, and I also fixed a typo.

Learning :) Would take care of it next time.

Last edited 2 years ago by mrahmadawais (previous) (diff)

#15 in reply to: ↑ 10 @maedahbatool
2 years ago

Replying to davidakennedy:

Good work @maedahbatool and @mrahmadawais! Made a few small tweaks. Stylesheets need updated version numbers too. It's always a good time to check copyright dates on the themes, and I also fixed a typo.

Thank You @davidakennedy and @mrahmadawais. Looking forward to improving my contribution in the upcoming releases. 😇

This ticket was mentioned in Slack in #forums by zoonini. View the logs.


2 years ago

#17 @davidakennedy
2 years ago

@maedahbatool @mrahmadawais Thanks again to you both! I've updated the changelogs for Twenty Fourteen, Fifteen and Seventeen since there were changes in the themes not listed there for this release.

This was a bit weird, and hard to track because of the way we've done a few minor releases in the past six months. So some commits got pushed out in minor releases, but others didn't. So this included a lot of those other updates, especially for Twenty Seventeen.

We have documentation on how to do a lot of this here: https://make.wordpress.org/core/handbook/about/release-cycle/update-bundled-themes/ Would love your feedback. What needs more explanation? I plan to make some changes there later today.

Feel free to drop the feedback in the core-themes Slack channel or ping me directly on Slack. I'd love to get other people comfortable with parts of this process.

Note: See TracTickets for help on using tickets.