Passing a float as the position in add_menu_page can override other menu items

[justinbusa]

If you pass a float value for the $position argument of add_menu_page, PHP will convert it to an integer which overrides any other menu items with that position.

Per the ​PHP docs...

Floats are also cast to integers, which means that the fractional part will be truncated. E.g. the key 8.7 will actually be stored under 8.

You can see this happening with the following snippet. The Test 2 menu item will show but Test 1 will not.

<?php
add_action( 'admin_menu', function() {
        add_menu_page( 'Test 1', 'Test 1', 'manage_options', 'test-1', '', '', 64 );
        add_menu_page( 'Test 2', 'Test 2', 'manage_options', 'test-2', '', '', 64.99 );
} );

However, if you pass 64.99 in as a string instead of a float, Test 1 will show.

Patch attached, thanks!

[dd32]

Previously: #23316

40927.diff​ is a bit more WordPress-like version of plugin.diff​.
I do wonder if we should just do something like this:

if ( ! is_int( $position ) && ! is_string( $position ) ) {
   $position = (string) $position;
}

[welcher]

Related #39776

[justinbusa]

@dd32 I agree as $position should always be either an int or a string. New patch attached.

[justinbusa]

Actually, I think that's going to break the if ( null === $position ) statement below it. New patch attached.

[dd32]

Thanks for catching that! 40927.3.diff​ looks good to me.

I'll loop back onto this later to test it properly, and see if there's any unit testing opportunity here (not an easy one I don't think).

[justinbusa]

Great! Thanks for checking it out.

[SergeyBiryukov]

#50534 was marked as a duplicate.

[SergeyBiryukov]

#51869 was marked as a duplicate.

[kirtan95]

@SergeyBiryukov @audrasjb This can be marked as fixed. I have handled this in https://core.trac.wordpress.org/ticket/54798

[audrasjb]

Right. But then I'd keep this ticket open to also take care of add_submenu_page.