WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 5 weeks ago

#40929 closed defect (bug) (fixed)

Dashboard: Add context to URL string in Nearby Events & News dashboard widget

Reported by: zodiac1978 Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: minor Version: 4.8
Component: Administration Keywords: good-first-bug has-patch
Focuses: Cc:

Description

In the new "Nearby Events and News" dashboard widget there is a link to the News section of (xx.)wordpress.org at the bottom of the widget

This string already exists for one of the Feed-URL, so the strings are identical and if we want to have different translations for each of them, it is not possible.

These are the strings:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/dashboard.php?marks=1117#L1117
and
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/dashboard.php?marks=1288#L1288

One of the links should get a context, so that we can translate these links differently.

Attachments (1)

40929.diff (781 bytes) - added by zodiac1978 2 months ago.

Download all attachments as: .zip

Change History (12)

#1 @zodiac1978
2 months ago

  • Keywords needs-patch added

#2 @iandunn
2 months ago

  • Keywords good-first-bug added
  • Severity changed from normal to minor

@zodiac1978
2 months ago

#3 @zodiac1978
2 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed

Added patch to add the context. I'm unsure if the wording of the context is fine.

Is it too late for 4.8 or do we get this little fix in?

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 months ago

#5 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 4.8.1

#6 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#7 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 40905:

I18N: Add context for News blog URL in 'WordPress Events and News' dashboard widget.

Props zodiac1978.
Fixes #40929.

#8 @SergeyBiryukov
2 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.8.1 consideration.

#9 @SergeyBiryukov
2 months ago

  • Keywords fixed-major added; dev-feedback removed

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


5 weeks ago

#11 @SergeyBiryukov
5 weeks ago

  • Keywords fixed-major removed
  • Milestone changed from 4.8.1 to 4.9
  • Resolution set to fixed
  • Status changed from reopened to closed

Per a brief discussion during the bug scrub linked above, we're trying to minimize string changes in 4.8.1, so closing as fixed in 4.9.

Note: See TracTickets for help on using tickets.