Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #40938, comment 6


Ignore:
Timestamp:
01/22/2018 12:27:17 PM (4 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40938, comment 6

    initial v1  
    11Perhaps for now we should add `package-lock.json` and even `yarn.lock` to svn ignore and gitignore. There is no point in producing "messy" diffs with unversioned files, and tripping up people that want to make a patch. They can be "unignored" easily when the time comes.
    22
    3 I'm also not so keen on using (yet another) package to keep these lock files synced. See the caveats section in the sunp docs: https://www.npmjs.com/package/synp#caveats. Ideally we should stick to either `package-lock.json` or `yarn.lock` and ignore the other.
     3I'm also not so keen on using (yet another) package to keep these lock files synced. See the caveats section in the synp docs: https://www.npmjs.com/package/synp#caveats. Ideally we should stick to either `package-lock.json` or `yarn.lock` and ignore the other.