WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #40938, comment 6


Ignore:
Timestamp:
01/22/2018 12:31:16 PM (4 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40938, comment 6

    v1 v2  
    1 Perhaps for now we should add `package-lock.json` and even `yarn.lock` to svn ignore and gitignore. There is no point in producing "messy" diffs with unversioned files, and tripping up people that want to make a patch. They can be "unignored" easily when the time comes.
     1Perhaps for now we should add `package-lock.json` and even `yarn.lock` to svn ignore and gitignore. There is no point in producing "messy" diffs with warnings about unversioned files, and tripping up people that want to make a patch. They can be "unignored" easily when the time comes.
    22
    33I'm also not so keen on using (yet another) package to keep these lock files synced. See the caveats section in the synp docs: https://www.npmjs.com/package/synp#caveats. Ideally we should stick to either `package-lock.json` or `yarn.lock` and ignore the other.