WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#40942 closed task (blessed) (fixed)

Update $_old_files for 4.8

Reported by: ocean90 Owned by: azaozz
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.8
Component: Upgrade/Install Keywords: has-patch commit dev-feedback
Focuses: Cc:
PR Number:

Description

tinymce/plugins/wpembed is missing for [40019].

Attachments (2)

40942.patch (688 bytes) - added by ocean90 2 years ago.
40942.2.patch (578 bytes) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (10)

@ocean90
2 years ago

#1 @ocean90
2 years ago

  • Keywords commit dev-feedback added
  • Owner set to azaozz
  • Status changed from new to reviewing

@azaozz @jorbin How does 40942.patch look to you?

#2 @azaozz
2 years ago

40942.patch looks good, +1 for commit.

@ocean90
2 years ago

#3 @ocean90
2 years ago

@azaozz Sorry, 40942.2.patch is all what we need here. We're using $wp_filesystem->delete($old_file, true);, so delete() is called in recursive mode.

#4 @jorbin
2 years ago

@ocean90 Should there be a comment just in case we stop recursive mode one day?

#5 @ocean90
2 years ago

@jorbin Where'd you place the comment? It's not the first directory in that array.

#6 @jorbin
2 years ago

Fair point. Let's commit 40942.2.patch

#7 @ocean90
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 40879:

Upgrade: Add wp-includes/js/tinymce/plugins/wpembed to $_old_files.

See #39513.
Fixes #40942.

#8 @ocean90
2 years ago

In 40880:

Upgrade: Add wp-includes/js/tinymce/plugins/wpembed to $_old_files.

Merge of [40879] to the 4.8 branch.

See #39513, #40942.

Note: See TracTickets for help on using tickets.