WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#40959 closed enhancement (fixed)

Twenty Seventeen: Periscope Social Icon Missing

Reported by: neildaniels Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description

It would be great to have a Periscope icon provided in the icon set that shows up in the "Social Icons Menu" at the bottom of the Twenty Seventeen theme.

As of Twenty Seventeen 1.3, providing a Periscope link just shows a generic "link chain" icon.

Attachments (3)

40959.diff (1.4 KB) - added by xkon 2 years ago.
Periscope Social Icon Patch
periscope.png (1.5 KB) - added by xkon 2 years ago.
Periscope Preview
40959.2.diff (1.4 KB) - added by xkon 2 years ago.
Spacing to tab

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
2 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Periscope Social Icon Missing in Twenty Seventeen Theme to Twenty Seventeen: Periscope Social Icon Missing

@xkon
2 years ago

Periscope Social Icon Patch

@xkon
2 years ago

Periscope Preview

#2 @xkon
2 years ago

  • Keywords has-patch 2nd-opinion reporter-feedback added

Hello,

40959.diff adds the periscope icon into the appropriate svg file. Each link that has pscp.tv as a url will now have the new icon.

Preview with

Deviantart / Periscope / Twitter
https://core.trac.wordpress.org/raw-attachment/ticket/40959/periscope.png

Best regards,
Konstantinos

This ticket was mentioned in Slack in #core-themes by xkon. View the logs.


2 years ago

#4 @xkon
2 years ago

  • Focuses ui added
  • Keywords 2nd-opinion reporter-feedback removed

This ticket was mentioned in Slack in #core-themes by xkon. View the logs.


2 years ago

#6 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.9

This ticket was mentioned in Slack in #core by xkon. View the logs.


2 years ago

@xkon
2 years ago

Spacing to tab

#8 @xkon
2 years ago

Updated to .2 fix code spacing for readability.

Could be added along #41529 as well.

Last edited 2 years ago by xkon (previous) (diff)

#9 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41592:

Twenty Seventeen: Add Periscope icon to supported social links.

Props xkon.
Fixes #40959.

Note: See TracTickets for help on using tickets.