WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#40966 assigned defect (bug)

Double clicking the Update plugins-button gives... interesting experience!

Reported by: bitnissen Owned by: swissspidy
Milestone: Future Release Priority: normal
Severity: normal Version: 4.6
Component: Upgrade/Install Keywords: shiny-updates good-first-bug has-patch
Focuses: Cc:
PR Number:

Description

Hi there,

I just updated to 4.8 on a bunch of sites and in one site I accidentally clicked the "Update"-button multiple times. What then happened, was a rather weird experience: After the update of the plugins successfully completed, it did another run where all updates apparently failed.

I tried this on multiple 4.8-installs, all has the same behaviour, so I guess it's fairly easy to reproduce. I've also recorded a video:

http://d.pr/v/qmoc7E/5MFtrVpY.mp4

Steps to reproduce:

  • Upgrade to 4.8.
  • Go to "Plugins" » "Updates available" (you need at least a plugin that has updates ready for it)
  • Select all update-ready plugins.
  • Click the "Update"-button. Then click it again.
  • Observe the table of plugins :-)

Kind regards,
Morten

Attachments (5)

40966.diff (1.2 KB) - added by MarcGuay 2 years ago.
40966.2.diff (900 bytes) - added by MarcGuay 2 years ago.
Remove extra line
40966.3.diff (1.9 KB) - added by xkon 2 years ago.
On Update only and re enable on all notices just in case.
40966.4.diff (812 bytes) - added by xkon 2 years ago.
Noop update
40966.5.diff (3.6 KB) - added by swissspidy 2 years ago.

Download all attachments as: .zip

Change History (15)

#1 @swissspidy
3 years ago

  • Keywords shiny-updates needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to swissspidy
  • Status changed from new to assigned
  • Version changed from 4.8 to 4.6

Hey there,

Welcome to WordPress Trac and thanks for your report!

I'm pretty sure this isn't new in WordPress 4.8. This functionality was introduced in 4.6 with Shiny Updates. We've previously fixed this bug in the feature plugin (see https://github.com/obenland/shiny-updates/issues/145), but I guess not every instance of it.

#2 @MarcGuay
2 years ago

Because the Apply button is a submit input and not an anchor like in the other case, the solution will be a bit different. It seems that it will need the disabled property added somewhere in the click event in wp-admin/js/updates.js starting at line 1999, and then removed once the queue is finished working, but it's not obvious to me at the moment, it's my first time looking at this code.

@MarcGuay
2 years ago

@MarcGuay
2 years ago

Remove extra line

@xkon
2 years ago

On Update only and re enable on all notices just in case.

#3 @xkon
2 years ago

  • Keywords has-patch added; needs-patch removed

For some weird reason ( just in case it was working for you ) @MarcGuay s code was not disabling the button at all on my installation.

Either way I placed the code a little differently on ( 40966.3.diff ). It will disable the Apply button only in case of 'update-selected' and re-enable it either way whenever there's a notice. I think it's safer this way and at least it works for my installation.

Best regards,
Konstantinos

This ticket was mentioned in Slack in #core by xkon. View the logs.


2 years ago

#5 @afercia
2 years ago

Please don't set disabled on focused elements because this will trigger a focus loss when using a keyboard. ideally, to avoid double clicks, the button should just no-op. /cc @swissspidy

@xkon
2 years ago

Noop update

#6 @xkon
2 years ago

Changed the diff into 40966.4.diff to fix the issues that @afercia mentioned.

Hopefully this will pass. I already did my tests but more tests are always welcome.

Best regards,
Konstantinos

@swissspidy
2 years ago

#7 @swissspidy
2 years ago

Few notes:

  • Network admin for themes is probably affected too
  • The first patches don't work because of a11y rasons
  • 40966.4.diff is too broad. $('.updating-message') could be anything

What we really need is a way to disallow a specific theme/plugin that has already been updated.

The bulk action handler bails early if an item doesn't have the update class (like, when a plugin doesn't have an update). In theory this be used to fix this bug here. However, wp.updates.updatePlugin doesn't remove that update class after a successful update.

40966.5.diff fixes that by removing update with updating during the process.

#8 @xkon
2 years ago

I just tried your patch @swissspidy and I'm still able to hit the Apply button resulting in plugins update failed.

I thought the idea was to not being able to re-send the update command by 'disabling' the Apply button so we don't get update errors. That's why by reading if the 'updating-message' exists somewhere in the page which is a class added only when something is currently being updated the button is just doing nothing. The 'updating-message' is also binded and checked only if you have the 'update' selected from your list and I haven't seen any other lists containing the 'update-selected' option but I might be wrong here.

Anyway I'm new to this so I might be missing something. Though the .4 patch was cancelling the Apply action and no more update failures where showing. The .5 you uploaded is still giving Errors.

This is by hitting the Apply button 5 times in a row.

I'll take another swing at it as well as I never though of the Theme process as well.

https://cldup.com/U8hak1vi8g.png

Best regards,
Konstantinos

Last edited 2 years ago by xkon (previous) (diff)

#9 @xkon
2 years ago

@swissspidy , now that i see this again with fresh eyes - do you want me to apply your patch and rework my js on top of your new css classes ? Just in case that makes it good to get it onboard as well?

#10 @swissspidy
2 years ago

@xkon Sure, feel free to build upon 40966.5.diff.

Note: See TracTickets for help on using tickets.