WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #40966, comment 8


Ignore:
Timestamp:
07/15/2017 07:51:25 PM (3 years ago)
Author:
xkon
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40966, comment 8

    v1 v2  
    11I just tried your patch @swissspidy and I'm still able to hit the Apply button resulting in plugins update failed.
    22
    3 I thought the idea was to not being able to re-send the update command by 'disabling' the Apply button so we don't get update errors. That's why by reading if the 'updating-message' exists somewhere in the page which is a class added only when something is currently being updated the button is just doing nothing.
     3I thought the idea was to not being able to re-send the update command by 'disabling' the Apply button so we don't get update errors. That's why by reading if the 'updating-message' exists somewhere in the page which is a class added only when something is currently being updated the button is just doing nothing. The 'updating-message' is also binded and checked only if you have the 'update' selected from your list and I haven't seen any other lists containing the 'update-selected' option but I might be wrong here.
    44
    55Anyway I'm new to this so I might be missing something. Though the .4 patch was cancelling the Apply action and no more update failures where showing. The .5 you uploaded is still giving Errors.