WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 6 months ago

#40978 closed defect (bug) (fixed)

Customizer Panel Footer border missing

Reported by: brentjett@… Owned by: westonruter
Milestone: 4.8.1 Priority: normal
Severity: normal Version: 4.8
Component: Customize Keywords: has-patch commit fixed-major
Focuses: ui Cc:

Description

There's a small visual inconsistency in the customizer panel. Everything but the footer has a 1px border. The footer area is missing the right edge.

Attachments (2)

Screen Shot 2017-06-09 at 9.35.03 AM.png (6.2 KB) - added by brentjett@… 8 months ago.
Missing border on right edge of panel footer.
40978.1.diff (369 bytes) - added by timmydcrawford 8 months ago.

Download all attachments as: .zip

Change History (9)

@brentjett@…
8 months ago

Missing border on right edge of panel footer.

#1 @westonruter
8 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.8.1

Regression introduced by [40511] for #32296.

This ticket was mentioned in Slack in #design by brentjett. View the logs.


8 months ago

#3 @timmydcrawford
8 months ago

  • Keywords has-patch added; needs-patch removed

40978.1.diff removes a pixel from the % based width so the right border is properly shown:

https://cloudup.com/cKB9WXKRfT8

The plain width: 18% should ensure backwards compat prior to IE11 - though the right border will be missing on older IE versions.

#4 @westonruter
8 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 40896:

Customize: Restore right border on footer actions.

Fixes regression introduced in [40511].

Props timmydcrawford.
See #32296.
Fixes #40978.

#5 @westonruter
8 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for consideration in 4.8.1 and merging onto 4.8 branch.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 months ago

#7 @westonruter
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41055:

Customize: Restore right border on footer actions.

Fixes regression introduced in [40511].

Merges [40896] onto 4.8 branch.
Props timmydcrawford.
See #32296.
Fixes #40978 for 4.8.1.

Note: See TracTickets for help on using tickets.