WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#4098 closed defect (bug) (invalid)

wp_cache group 'pages' is created but never used

Reported by: kevinB Owned by: rob1n
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: cache page_cache
Focuses: Cc:

Description

The wp_cache group 'pages' is populated by update_page_cache and deleted by clean_page_cache, but never retrieved by any core code.

This seems to add needless overhead, especially considering the proposed patch in #4096 which would call update_page_cache more frequently.

Attachments (1)

functions.php-page_cache.diff (198 bytes) - added by kevinB 7 years ago.
Updated diff file changes nothing. Retract previous erroneous patch.

Download all attachments as: .zip

Change History (2)

kevinB7 years ago

Updated diff file changes nothing. Retract previous erroneous patch.

comment:1 kevinB7 years ago

  • Milestone 2.2 deleted
  • Resolution set to invalid
  • Status changed from new to closed

What was I thinking? Umm... the get_page function. Slap. Slap. Please forgive this gaffe. I'm confident my other tickets re: the get_ functions are worth a look.

One point does remain:

If we need to populate global $page_cache after a get_pages wpcache retrieval (see #4097), then update_page_cache(), as it exists now, would not be the right call because it would update the wp_cache needlessly.

Note: See TracTickets for help on using tickets.