WordPress.org

Make WordPress Core

#40997 closed defect (bug) (fixed)

Maintain expanded nav menu section once expanded section for placeholder is replaced with actual

Reported by: greuben Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Description


Attachments (2)

fix.patch (1.3 KB) - added by greuben 22 months ago.
fix.2.patch (1.3 KB) - added by westonruter 21 months ago.

Download all attachments as: .zip

Change History (7)

@greuben
22 months ago

#1 @westonruter
22 months ago

@greuben please elaborate in the description on what the defect is that you are fixing. Adding a videos showing before/after the fix would be helpful.

#2 @greuben
22 months ago

@westonruter When a new menu is created in customizer, "Save & Publish" will collapse the section. The patch fixes that.

Before: https://youtu.be/KWzHVJXN84s
After: https://youtu.be/Jdy-ZpCSTbk

#3 @westonruter
22 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.9
  • Summary changed from Expand active menu section in api.Menus.applySavedData to Maintain expanded nav menu section once expanded section for placeholder is replaced with actual

@greuben Thanks. This issue will also be resolved by #38072.

@westonruter
21 months ago

#4 @westonruter
21 months ago

  • Owner set to westonruter
  • Status changed from new to accepted
  • Version changed from trunk to 4.3

#5 @westonruter
21 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41001:

Customize: Fix logic to re-expand a newly inserted nav menu section after placeholder section is replaced.

Fixes todo from Menu Customizer feature plugin: https://github.com/voldemortensen/menu-customizer/commit/0f4ea4e#diff-daa55fade2253f26ccbe02f71058841cR2330
Amends [32806].
Props greuben.
See #32576.
Fixes #40997.

Note: See TracTickets for help on using tickets.