WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 8 years ago

#410 closed defect (bug) (fixed)

post via mail

Reported by: davidcrickett Owned by:
Milestone: 2.2 Priority: normal
Severity: minor Version:
Component: Administration Keywords: wp-mail has-patch 2nd-opinion
Focuses: Cc:

Description

If you use this trick, then you don't get the noop error anymore:

To fix, edit wp-includes/class-pop3.php, and change this line:

if($this->RFC1939) {

to this:

if(!$this->RFC1939) {

(add exclamation point).

...but this instead:

Fatal error: Call to undefined function: logio() in /hotel/yoursite/WWW/wp-includes/functions-post.php on line 170

Attachments (2)

wp-mail-fix.diff.txt (757 bytes) - added by davidcrickett 10 years ago.
wp-mail-fix2.diff.txt (1.7 KB) - added by davidcrickett 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:2 @Froosh11 years ago

My "instant-analysis" indicates that the logio calls are from old debug style code. Commenting them out removes the error.

But then I get this:

Database error: [You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND category_id = 7' at line 1]
SELECT * FROM robin_post2cat WHERE post_id = AND category_id = 7

$post_ID does not get populated after the wp_insert_post($post_data) call.

I'm not familiar enough with wp_insert_post operation at the moment to work out why. I'll look at it more later.

Update 23-Nov-04:
The second error I got is because wp-mail.php is currently broken and just adds junk to the DB.

Diff uploaded for a quick fix: creates and adds "$post_status" to the array passed to wp_insert_status and adds "$post_ID =" to the wp_insert_post call

Update 24-Nov-04:
New diff uploaded contains:

Fixes from my first diff ($post_ID and $post_status).
Minor fix for correct closure of POP3 object if no mail exists.
Removed the whole $post_categories section at the end as it is already taken care of in wp_insert_post()

edited on: 11-24-04 11:44

comment:3 @2fargon11 years ago

  • Patch set to Yes
  • Status changed from new to assigned

comment:4 @2fargon11 years ago

  • Severity changed from major to minor

comment:5 @skippy10 years ago

  • Keywords bg|has-patch bg|2nd-opinion added

These might be helpful modifications to wp-mail, too.

And it would be nice to update wp-mail so that people can use GMail, too. GMail uses POP3-over-SSL, so wp-mail will need to speak SSL.

comment:6 @skippy10 years ago

  • Keywords wp-mail added

comment:7 @skippy10 years ago

  • Owner changed from anonymous to skippy
  • Status changed from assigned to new

comment:8 @foolswisdom9 years ago

  • Keywords has-patch 2nd-opinion added; bg|has-patch bg|2nd-opinion removed
  • Milestone set to 2.1

comment:9 @matt9 years ago

  • Milestone changed from 2.1 to 2.2

comment:10 @rob1n8 years ago

  • Owner skippy deleted

comment:11 @foolswisdom8 years ago

  • Milestone changed from 2.2 to 2.4

davidcrickett, can you test and see if you are experiencing this issue on trunk? phpmailer was integrated.

comment:12 @Nazgul8 years ago

  • Milestone changed from 2.4 to 2.2
  • Resolution set to fixed
  • Status changed from new to closed

Fixed by [4945]

Note: See TracTickets for help on using tickets.