Make WordPress Core

Opened 3 years ago

Last modified 2 months ago

#41024 reviewing defect (bug)

File uploader looks misaligned in Mac Chrome

Reported by: Ankit K Gupta Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version: 4.8
Component: Plugins Keywords: has-patch has-screenshots
Focuses: administration Cc:


Plugin/theme file uploader look misaligned in Mac Chrome. Refer attached screen shots.
Browser default uploader text appearing on select file button and it makes text long.
I am not expert in CSS but I noticed if change max-width of form. It looks fine in All Browsers.
Better solution are welcome :)

Attachments (5)

Mac Chrome.jpg (26.8 KB) - added by Ankit K Gupta 3 years ago.
Windows Chrome.jpeg (46.7 KB) - added by Ankit K Gupta 3 years ago.
41024.patch (386 bytes) - added by Ankit K Gupta 3 years ago.
After Fix.jpg (26.2 KB) - added by Ankit K Gupta 3 years ago.
41024.2.patch (381 bytes) - added by gingeds 3 years ago.
CSS Coding Standards fix

Download all attachments as: .zip

Change History (9)

@Ankit K Gupta
3 years ago

#1 @Ankit K Gupta
3 years ago

  • Keywords has-patch has-screenshots added

#2 @gingeds
3 years ago

Good work!

I changed it to 400px and attached file above - as WordPress CSS Coding Standards states magic numbers are unlucky.

See: https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#best-practices


Last edited 3 years ago by gingeds (previous) (diff)

3 years ago

CSS Coding Standards fix

This ticket was mentioned in Slack in #core-media by mike. View the logs.

20 months ago

#4 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.