Opened 7 years ago
Closed 4 years ago
#41024 closed defect (bug) (worksforme)
File uploader looks misaligned in Mac Chrome
Reported by: | Ankit K Gupta | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 4.8 |
Component: | Plugins | Keywords: | has-patch has-screenshots close |
Focuses: | administration | Cc: |
Description
Plugin/theme file uploader look misaligned in Mac Chrome. Refer attached screen shots.
Browser default uploader text appearing on select file button and it makes text long.
I am not expert in CSS but I noticed if change max-width of form. It looks fine in All Browsers.
Better solution are welcome :)
Attachments (8)
Change History (17)
This ticket was mentioned in Slack in #core-media by mike. View the logs.
6 years ago
#4
@
4 years ago
- Milestone changed from Awaiting Review to 5.6
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#5
@
4 years ago
I don't show this as being an issue anymore. The relevant selectors .upload-theme .wp-upload-form, .upload-plugin .wp-upload-form
have since been updated to use flexbox so I think this can be closed as fixed.
FYI: I am on Mac OS Catalina using Chrome Version 86.0.4240.111 to view a baseline install of WordPress 5.5.1. See attached screenshot.
What do you think, @SergeyBiryukov?
@
4 years ago
Upload plugin (add plugin file) screen on Mac with Chrome: dragging in and out to responsively resize. Result: no misalignment.
@
4 years ago
Upload theme (add theme file) screen on Mac with Chrome: dragging in and out to responsively resize. Result: no misalignment.
#6
@
4 years ago
I concur with @metalandcoffee. I did not witness an alignment issue either on my Macbook (see uploaded gifs). Tested:
- Chrome Version 86.0.4240.111 (Official Build) (x86_64)
- macOS Catalina version 10.15.7
- Current
wordpress-develop
master
branch, ie version5.6-beta1-49262-src
This issue appears to be resolved.
Good work!
I changed it to 400px and attached file above - as WordPress CSS Coding Standards states magic numbers are unlucky.
See: https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#best-practices
Cheers!