Opened 9 years ago
Closed 9 years ago
#41052 closed defect (bug) (fixed)
Need validation update in video widget
| Reported by: | ravipatel | Owned by: | westonruter |
|---|---|---|---|
| Priority: | high | Milestone: | 4.9 |
| Component: | Widgets | Version: | 4.8 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | Focuses: | ui, javascript |
Description
Without Validation not insert video widget content.
When i have insert just text not validate this one.
Attachments (7)
Change History (18)
#2
@
9 years ago
- Resolution → invalid
- Status new → closed
Same issue with image and audio widget also. please mark this one.
#3
@
9 years ago
@ravipatel I don't think we should be accepting invalid URLs though. It should have the required extension or be a valid oEmbed. So is this not valid?
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
9 years ago
#7
@
9 years ago
- Keywords has-patch added; needs-patch removed
Directly relates to #34115 which will impact how we handle arbitrary URLs for video embeds. We'll use the oEmbed response then to validate URLs that don't match the supplied pattern.
#9
@
9 years ago
- Priority normal → high
Bumping priority to high for visibility and alignment with 4.9 goals, and given proximity to beta 1 deadline.
#10
@
9 years ago
@gk.loveweb I iterated on your patch a bit and I think I came to something that works better in 41052.4.diff. Would you give it a try? By moving the logic to updateoEmbed we can short-circuit the fetch logic earlier, since updateoEmbed is what calls fetch to begin with.
The audio widget needs some more work, I believe. For one it doesn't support oEmbeds at all currently.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
@timmydcrawford This seems to relate to #40935.