Need validation update in video widget

[ravipatel]

Without Validation not insert video widget content.

When i have insert just text not validate this one.

[westonruter]

@timmydcrawford This seems to relate to #40935.

[ravipatel]

Same issue with image and audio widget also. please mark this one.

[westonruter]

@ravipatel I don't think we should be accepting invalid URLs though. It should have the required extension or be a valid oEmbed. So is this not valid?

[jbpaul17]

Punting to 4.9 per today's bug scrub.

[gk.loveweb]

Fixes for video widget

[westonruter]

Directly relates to #34115 which will impact how we handle arbitrary URLs for video embeds. We'll use the oEmbed response then to validate URLs that don't match the supplied pattern.

[westonruter]

Bumping priority to high for visibility and alignment with 4.9 goals, and given proximity to beta 1 deadline.

[octalmage]

Patch didn't apply, refreshed at 4.8.2.

[westonruter]

@gk.loveweb I iterated on your patch a bit and I think I came to something that works better in 41052.4.diff​. Would you give it a try? By moving the logic to updateoEmbed we can short-circuit the fetch logic earlier, since updateoEmbed is what calls fetch to begin with.

The audio widget needs some more work, I believe. For one it doesn't support oEmbeds at all currently.

[westonruter]

In 41933:

Widgets: Harden logic for checking for valid media URLs.

• Update deprecated isHostedVideo method to always return true since all oEmbeds are now supported.
• Disable scanImage for non-image media widgets.
• Ensure embed URL field element is matched from current media frame instance due to bug where media frames are not destroyed upon closing.
• Update error message for invalid video URLs to ask user to check the URL for validity.

Props gk.loveweb, octalmage, westonruter.
See #42039, #40935.
Fixes #41052.