Make WordPress Core

Opened 4 years ago

Last modified 2 years ago

#41057 closed task (blessed)

Update PHP codebase per WordPress PHP Coding Standards — at Version 1

Reported by: netweb Owned by: pento
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: General Keywords: early commit
Focuses: coding-standards Cc:

Description (last modified by pento)


"That said, we want to be internally consistent and follow our own rules. Code is poetry, and our code should be beautiful."


As a first pass there are 8 files to this ticket for the initial patch, 4 patches, and 4 file lists of the files to be patched, these files lists exclude and 3rd party external PHP libraries so that the only files changed are WordPress' PHP files

  • 41057-src-root.diff generated from the 41057-filelist-src-root.txt PHP file list
  • 41057-src-wp-admin.diff generated from the 41057-filelist-src-wp-admin.txt PHP file list
  • 41057-src-wp-content.diff generated from the 41057-filelist-src-wp-content.txt PHP file list
  • 41057-src-wp-includes.diff generated from the 41057-filelist-src-wp-includes.txt PHP file list

Each of the above diff/patches are generated programmatically by phpcbf part of phpcs using the WordPress-Core version 0.11.0 PHP Codesniffer ruleset from https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards

  • phpcbf --file-list=41057-filelist-src-root.txt --standard=WordPress-Core --extensions=php
  • phpcbf --file-list=41057-filelist-src-wp-admin.txt --standard=WordPress-Core --extensions=php
  • phpcbf --file-list=41057-filelist-src-wp-content.txt --standard=WordPress-Core --extensions=php
  • phpcbf --file-list=41057-filelist-src-wp-includes.txt --standard=WordPress-Core --extensions=php

Change History (9)

#1 @pento
4 years ago

  • Description modified (diff)
  • Owner set to pento
  • Status changed from new to accepted

Before we do this, I would like us to take a moment and review the Coding Standards. Is there anything we'd like to change? I don't want to make such a huge commit if we're going to follow it up with another huge commit for some standards tweak.

Note: See TracTickets for help on using tickets.