WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41074, comment 23


Ignore:
Timestamp:
10/12/2017 04:00:46 PM (7 years ago)
Author:
folletto
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #41074, comment 23

    initial v1  
    11A few more details that I got from when I created the current Dashicons build script
    22
    3 1. The build script can generate either a file or embedded (not both), in the discussion we chose to use the embedded one ([chat](https://wordpress.slack.com/archives/C03EESJAW/p1499451473651201)):
    4 2. Which means: `dashicons.css` is generated with '''embedded''' WOFF, so there's no file used ([source](https://github.com/WordPress/dashicons/blob/master/icon-font/dashicons.css#L15)).
     31. The build script can generate either a file or embedded (not both), in the discussion we chose to use the embedded one ([https://wordpress.slack.com/archives/C03EESJAW/p1499451473651201) chat]).
     42. Which means: `dashicons.css` is generated with '''embedded''' WOFF, so there's no file used ([https://github.com/WordPress/dashicons/blob/master/icon-font/dashicons.css#L15 source]).
    55
    66Which means that the new CSS from the Dashicon repository includes the WOFF content inline, making no use of the WOFF file as a separate file.