WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #41074, comment 55


Ignore:
Timestamp:
04/30/2018 06:46:41 AM (16 months ago)
Author:
Joen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41074, comment 55

    v1 v2  
    11> @Joen are there any Gutenberg-related icons that would be good to land before 5.0 or are you all ok waiting for those icons to land alongside Gutenberg in 5.0?
    22
    3 We don't _need_ any icons to land before 5.0, no. In fact, for now and because we've needed to be able to create icons for Gutenberg _fast_, every new icon created for Gutenberg are in a separate directory: https://github.com/WordPress/dashicons/tree/master/sources/svg/gutenberg
     3We don't ''need'' any icons to land before 5.0, no. In fact, for now and because we've needed to be able to create icons for Gutenberg ''fast'', every new icon created for Gutenberg are in a separate directory: https://github.com/WordPress/dashicons/tree/master/sources/svg/gutenberg
    44
    5 Icons in that directory are not added into the icon font, they are added only to the react component. But anyone should feel free to comment on their design.
     5Icons in that directory are not added into the icon font, they are added only to the react component. Gutenberg doesn't use the icon font at all. But anyone should feel free to comment on their design.
    66
    77I think the most important thing to review, though, is the new build process. Recent work was done in https://github.com/WordPress/dashicons/pull/246. The build process means that creating new icons is not an arduous process, which is important so as to keep the project alive. It comes with only two changes per how it's been done in the past: