WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41083, comment 19


Ignore:
Timestamp:
09/05/2017 03:32:55 PM (2 years ago)
Author:
iandunn
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41083, comment 19

    initial v1  
    55Since we really only need to know if the input is formatted as an IPv4 address or an IPv6 address, we can use a quick and dirty method, like in [attachment:41083.2.diff].
    66
    7 Another idea would be to update `WP_Http::is_ip_address()` to support port numbers, but that could turn into a rabbit hole with  unintended consequences, especially since it's outside the class (by the REST API and plugins).
     7Another idea would be to update `WP_Http::is_ip_address()` to support port numbers, but that could turn into a rabbit hole with  unintended consequences, especially since it's used outside the class (by the REST API and plugins).
    88
    99Yet another idea would be using `@` to suppress the warnings, but that's pretty hacky, and could unintentionally hide errors that we'd want to fix.