WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 3 months ago

#41094 new defect (bug)

Deprecated version not specfied for debug_fopen() et al.

Reported by: jdgrimes Owned by:
Milestone: 4.9 Priority: normal
Severity: normal Version: 3.4
Component: General Keywords: has-patch needs-refresh
Focuses: Cc:

Description

The debug_fopen(), debug_write() and debug_fclose() functions were deprecated in 3.4.0 ([19935]). However, the calls to _deprecated_function() do not include the version number, instead listing the replacement function, error_log() as the second parameter. The second parameter is supposed to be the version number, the replacement function should be the third parameter.

Attachments (1)

41094.diff (1.0 KB) - added by milindmore22 3 months ago.

Download all attachments as: .zip

Change History (8)

#1 @jdgrimes
3 months ago

  • Keywords good-first-bug added

#2 @swissspidy
3 months ago

  • Keywords needs-patch added

@milindmore22
3 months ago

#3 @milindmore22
3 months ago

  • Keywords has-patch added; needs-patch removed

#4 @netweb
3 months ago

  • Keywords commit added; good-first-bug removed
  • Milestone changed from Awaiting Review to 4.9

Looks good to me, thanks @milindmore22

#5 follow-up: @jrf
3 months ago

There are a number of other functions suffering from this. Shall I add additional patches for those to this ticket or should I open a new ticket ? Or even a new ticket for each patch ?

#7 in reply to: ↑ 5 @netweb
3 months ago

  • Keywords needs-refresh added; commit removed

Replying to jrf:

There are a number of other functions suffering from this. Shall I add additional patches for those to this ticket or should I open a new ticket ? Or even a new ticket for each patch ?

Sounds good, updating the patch here by including 41094.diff in your patch @jrf and it can go in in a single commit with props to you both @milindmore22 and @jrf

Note: See TracTickets for help on using tickets.