WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 16 months ago

#41114 new enhancement

Installation: "Search Engine Visibility" not keeping checked on error

Reported by: screamingdev Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.8
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Given your installing WordPress
and you reach the screen about site title, admin login and "Search Engine Visibility".

When you enable the checkbox for/near "Search Engine Visibility"
And fill nothing out for mail address
And press continue

Then an error message appears
And most fields are still filled out as before

---

Problem:

The "Search Engine Visibility" is no longer checked.
IMHO this should also stay as intended to.

Attachments (1)

41114.diff (590 bytes) - added by donmhico 16 months ago.

Download all attachments as: .zip

Change History (3)

#1 @screamingdev
3 years ago

  • Summary changed from Search Engine Visibility to Installation: "Search Engine Visibility" not keeping checked on error

@donmhico
16 months ago

#2 @donmhico
16 months ago

  • Keywords has-patch added

At first I thought that it might be the intended behaviour to always get the user to check but checking at source code

<input name="blog_public" type="checkbox" id="blog_public" value="0" <?php checked( 0, $blog_public ); ?> />

We can see the checked function is being used. If the intent is to always make the user perform the check then checked() shouldn't be there.

Anyway, my attached patch, 41114.diff, should fix this.

Note: See TracTickets for help on using tickets.