Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#41117 closed enhancement (fixed)

Text color is too light for install message on multisite sites

Reported by: mbootsman's profile mbootsman Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.8
Component: Import Keywords: needs-screenshots has-patch
Focuses: ui, accessibility Cc:

Description

When trying to import on a site (as part of a network), and when that importer is not installed, a message is displayed. This message: 'This importer is not installed. Please install importers from the main site.' is displayed in color #ddd;

Would be better for readability and accessibility to use a more contrasting color, like #555, which is widely used in the admin.

Attachments (2)

20170621-Selection_006.png (29.8 KB) - added by mbootsman 7 years ago.
Screenshot added
41117.patch (363 bytes) - added by nishitlangaliya 7 years ago.
Fixed #41117 color changed to #555

Download all attachments as: .zip

Change History (9)

#1 @swissspidy
7 years ago

  • Component changed from Administration to Import
  • Keywords needs-screenshots added

@mbootsman
7 years ago

Screenshot added

#2 @melchoyce
7 years ago

Oh yeah, that is definitely not the right color. I think for now #555 is fine, until #40633 goes through.

@nishitlangaliya
7 years ago

Fixed #41117 color changed to #555

#3 follow-up: @nishitlangaliya
7 years ago

  • Keywords has-patch added

@swissspidy ,

Hi have added patch for change color from #ddd to #555 as per suggestion please review it when you get a chance and let me know if any changes requried.

Thanks

#4 in reply to: ↑ 3 ; follow-up: @mbootsman
7 years ago

Replying to nishitlangaliya:

@swissspidy ,

Hi have added patch for change color from #ddd to #555 as per suggestion please review it when you get a chance and let me know if any changes requried.

Thanks

Thanks for the patch.

#5 in reply to: ↑ 4 @nishitlangaliya
7 years ago

@mbootsman

You welcome :)

Replying to mbootsman:

Replying to nishitlangaliya:

@swissspidy ,

Hi have added patch for change color from #ddd to #555 as per suggestion please review it when you get a chance and let me know if any changes requried.

Thanks

Thanks for the patch.

#6 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.9

#7 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 40928:

Import: Increase color contrast for "This importer is not installed" message on Multisite.

Remove .not-installed-main-site class introduced in [38075], but never used.

Props nishitlangaliya, mbootsman.
Fixes #41117.

Note: See TracTickets for help on using tickets.