Make WordPress Core

Opened 8 years ago

Closed 3 weeks ago

#41142 closed enhancement (fixed)

Theme editing: inconstancies with messages between this and plugin editing

Reported by: karmatosed's profile karmatosed Owned by: poena's profile poena
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

The process is the same but we have different ways of saying it. For example even this:

https://cldup.com/ndD0DpUtS2.png

In the plugin it says:

https://cldup.com/MQ09SZmEdS.png

Attachments (1)

file-editors-2024-05-12-pr-7956.png (22.7 KB) - added by poena 3 months ago.
With PR 7956

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


8 years ago

#2 @poena
4 months ago

  • Milestone changed from Awaiting Review to 6.8
  • Owner set to poena
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement

#3 @poena
3 months ago

How about showing the active or inactive state after the theme or plugin name, and the file name below it, outside the H2 heading?

This ticket was mentioned in PR #7956 on WordPress/wordpress-develop by @poena.


3 months ago
#4

  • Keywords has-patch added

Update the header area of the theme and plugin file editor pages to be more consistent.

Display the name of theme or plugin, the active or inactive state, and the path to the file that is selected (including the file name).

Trac ticket: https://core.trac.wordpress.org/ticket/41142

@poena
3 months ago

With PR 7956

#5 @poena
2 months ago

  • Keywords needs-testing added

#6 @karmatosed
2 months ago

  • Keywords commit added; needs-testing removed

I like this and would love to see it in @poena. It closes out one ticket from #43622 work that has long standing remained open. I would love to see any of those done as part of this release so thank you for picking it up.

I can confirm in testing this works for me.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


8 weeks ago

@audrasjb commented on PR #7956:


8 weeks ago
#8

This PR looks ready to ship on my side 👌

#9 @karmatosed
4 weeks ago

@poena this has been reviewed and looks ready to ship. Can we look to get in or support that?

#10 @poena
4 weeks ago

@karmatosed I don't understand the question.
Are you asking why I have not committed it?

I am a theme committer, until the leadership responds about wether I am allowed to commit other tickets than bundled theme tickets, I don't feel comfortable doing that.

#11 @karmatosed
4 weeks ago

@poena I am not asking that no, I am asking what we can do collaboratively to support get it over the line.

#12 @poena
4 weeks ago

Well since it has been tested and there are no change requests, the only thing left is the commit.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 weeks ago

#14 @audrasjb
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 59884:

Themes: Fix inconstancies between theme and plugin editor.

This updates the header area of the theme and plugin file editor screen to make them more consistent. It now displays the name of theme or plugin, the active or inactive state, and the path to the file that is selected.

Props karmatosed, poena, audrasjb.
Fixes #41142.

Note: See TracTickets for help on using tickets.