Theme/plugin editing: if you don't select a function it just returns without message

[karmatosed]

The drop down simply returns nothing, could we have a message to say something like 'please search for something'? It feels a little of a hitch in the flow otherwise.

[xkon]

Modified the buttons jQuery code to show / hide an error message.

[xkon]

Hello,

I created a simple patch for this by just adding a span, showing it / hiding it respectively.

It's for both theme-editor.php and plugin-editor.php

Screenshot:

If there are more suggestions let me know to come up with something else.

Best regards,
Konstantinos

[swissspidy]

What about disabling the button as long as nothing is selected?

[xkon]

Sure I could fix a version like
that @swissspidy . To clarify it will be disabled by default and then accordingly changed if there's a selection .

I'll get on it after work. Question is there a js file that loads on admin globally it would be nicer to add a function there instead of inline. I have no clue first time contributing so I don't want to add things to wrong files ..

Best regards ,
Konatantinos

[xkon]

Diff for suggestion with disabled button.

[xkon]

Hello again,

I've added 41143_v2.diff this is @swissspidy 's suggestion to have the button disabled. I think it works better than the error message. At least it makes more sense and keeps the UI clean.

Unfortunately I added the code within the page as I don't know if I should add it to the minified common.js myself or if somebody will transfer it there.

Keep me posted if you need it in another file so I can fix an update for it.

Best regards,
Konstantinos

[xkon]

Disabled Button. Check code transfered to common.js

[xkon]

After talking with @swissspidy ( he helped me understand the dev svn correctly, so thanks again :) ) I've added the code into common.js instead to be nice and clean for production.

Added: 41143_v3.diff

Best regards,
Konstantinos

[xkon]

Just dropping by in case there's an update for this as well @karmatosed / @SergeyBiryukov , i reapplied the patch and it's still working by disabling the Look Up button

[westonruter]

41143_v3.diff​ needs to be refactored to be integrated with ​theme-plugin-editor.js, which is new in this release.

[xkon]

Intergration with theme-plugin-editor.js

[xkon]

@westonruter, I've added the code into theme-plugin-editor.js. It is working as supposed to but unfortunately I'm not that well versed to be honest and got lost a bit on how the 'refactoring' should work but at least I hope it's a start for someone to 'embed' it fully if this patch isn't viable.

If there are any pointers I'd gladly read up and re-work on it as every day is a new thing learned!

[xkon]

Refactor

[xkon]

41143_5.diff​ adds into theme-plugin-editor.js the checks for Documentation: Lookup Button.

Looking it with a fresh and clear mind I think this is ready.

[xkon]

Gif demonstration

[melchoyce]

Looks good to me 👍

[westonruter]

Instead of a method name of docsLookup I think it would be better to have something more descriptive and “verby” like updateDocsLookUpButtonDisabledState. I'm not sure even a separate method is needed there, actually. The toggling of the disabled prop could be done right in the change handler.

[xkon]

remove method

[xkon]

41143_6.diff​ removes the new method and does the check inside the change as @westonruter pointed out

[pento]

In 44617:

Plugin Editor: Disable the documentation look up button when no function is selected.

Props xkon.
Fixes #41143.