WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#41164 reviewing enhancement

Display theme screenshot in network admin

Reported by: johnbillion Owned by: johnbillion
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch has-screenshots has-unit-tests
Focuses: administration, multisite Cc:

Description

The screenshot for each theme should be displayed in a new column on the following list tables:

  • Network Admin -> Themes
  • Network Admin -> Sites -> Edit -> Themes

Attachments (6)

41164-style.patch (415 bytes) - added by mp518 2 years ago.
Added screenshot image size
41164.patch (2.1 KB) - added by mp518 2 years ago.
Added screenshot new column
Themes Network Admin Theme Sites.png (163.8 KB) - added by mp518 2 years ago.
Themes Network Admin Theme Sites.png
Edit Site Network Admin Theme Sites.png (119.1 KB) - added by mp518 2 years ago.
Edit Site Network Admin Theme
41164 (20.9 KB) - added by mp518 2 years ago.
here is diff
41164.1.patch (2.3 KB) - added by vagios 2 years ago.
Merged both patches and made some fixes.

Download all attachments as: .zip

Change History (11)

#1 @mp518
2 years ago

  • Keywords has-patch has-screenshots added; needs-patch removed

Hello @johnbillion,

This is good enhancement and i have created patch for this enhancement also attached screenshot after done this.can you review that patch and if any changes then let me know.

Note:Please ignore 41155.patch attachment because by mistake attached wrong patch.my apologize for that.

Thank You,
Mahesh

Last edited 2 years ago by mp518 (previous) (diff)

@mp518
2 years ago

Added screenshot image size

@mp518
2 years ago

Added screenshot new column

@mp518
2 years ago

Themes Network Admin Theme Sites.png

@mp518
2 years ago

Edit Site Network Admin Theme

@mp518
2 years ago

here is diff

@vagios
2 years ago

Merged both patches and made some fixes.

#2 @vagios
2 years ago

In 41164.1.patch I merged both patches into one. Also made some fixes,

  • Removed globals from column_screenshot documentation. (Also changed @since value)
  • Removed fixed width since it looked really bad in some cases and add some basic responsiveness to <img />. I am not sure how the screenshot should be presented but it looks as a good starting point.
  • Added alt and title attributes on <img />
  • Fixed some spacings in code.
Last edited 2 years ago by vagios (previous) (diff)

#3 @mp518
2 years ago

  • Keywords good-first-bug removed

#4 @johnbillion
2 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to johnbillion
  • Status changed from new to reviewing

#5 @kakshak
2 years ago

  • Keywords has-unit-tests added; needs-testing removed

Hello @johnbillion,
I have merged this patch in my local multi site environment and it's working fine.

Note: See TracTickets for help on using tickets.