Opened 6 years ago
Closed 11 months ago
#41164 closed enhancement (maybelater)
Display theme screenshot in network admin
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.0 |
Component: | Themes | Keywords: | has-patch has-screenshots needs-refresh |
Focuses: | administration, multisite | Cc: |
Description
The screenshot for each theme should be displayed in a new column on the following list tables:
- Network Admin -> Themes
- Network Admin -> Sites -> Edit -> Themes
Attachments (8)
Change History (16)
#2
@
6 years ago
In 41164.1.patch I merged both patches into one. Also made some fixes,
- Removed globals from
column_screenshot
documentation. (Also changed@since
value) - Removed fixed width since it looked really bad in some cases and add some basic responsiveness to
<img />
. I am not sure how the screenshot should be presented but it looks as a good starting point. - Added
alt
andtitle
attributes on<img />
- Fixed some spacings in code.
#4
@
6 years ago
- Keywords needs-testing added
- Milestone changed from Awaiting Review to Future Release
- Owner set to johnbillion
- Status changed from new to reviewing
#5
@
6 years ago
- Keywords has-unit-tests added; needs-testing removed
Hello @johnbillion,
I have merged this patch in my local multi site environment and it's working fine.
#6
@
3 years ago
- Keywords has-unit-tests removed
- Milestone changed from Future Release to 5.6
41164.diff is a refreshed patch. I quite like this. Any objections?
#7
@
3 years ago
- Keywords needs-refresh added
- Milestone changed from 5.6 to Future Release
- Owner johnbillion deleted
This still needs work due to width issues on narrow viewports and the horizontal space taken up by the automatic updates column. If someone wants to pick this up and test both screens (Network Admin -> Themes
and Network Admin -> Sites -> Edit -> Themes
) at small resolutions and with the auto updates column in place, that would be great.
Note: See
TracTickets for help on using
tickets.
Hello @johnbillion,
This is good enhancement and i have created patch for this enhancement also attached screenshot after done this.can you review that patch and if any changes then let me know.
Note:Please ignore 41155.patch attachment because by mistake attached wrong patch.my apologize for that.
Thank You,
Mahesh