WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 7 months ago

#41164 reviewing enhancement

Display theme screenshot in network admin

Reported by: johnbillion Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch has-screenshots needs-refresh
Focuses: administration, multisite Cc:

Description

The screenshot for each theme should be displayed in a new column on the following list tables:

  • Network Admin -> Themes
  • Network Admin -> Sites -> Edit -> Themes

Attachments (8)

41164-style.patch (415 bytes) - added by mp518 4 years ago.
Added screenshot image size
41164.patch (2.1 KB) - added by mp518 4 years ago.
Added screenshot new column
Themes Network Admin Theme Sites.png (163.8 KB) - added by mp518 4 years ago.
Themes Network Admin Theme Sites.png
Edit Site Network Admin Theme Sites.png (119.1 KB) - added by mp518 4 years ago.
Edit Site Network Admin Theme
41164 (20.9 KB) - added by mp518 4 years ago.
here is diff
41164.1.patch (2.3 KB) - added by vagios 4 years ago.
Merged both patches and made some fixes.
41164.diff (1.7 KB) - added by johnbillion 8 months ago.
Screenshot 2020-09-20 at 15.21.17.png (863.2 KB) - added by johnbillion 8 months ago.

Download all attachments as: .zip

Change History (15)

#1 @mp518
4 years ago

  • Keywords has-patch has-screenshots added; needs-patch removed

Hello @johnbillion,

This is good enhancement and i have created patch for this enhancement also attached screenshot after done this.can you review that patch and if any changes then let me know.

Thank You,
Mahesh

Version 1, edited 4 years ago by mp518 (previous) (next) (diff)

@mp518
4 years ago

Added screenshot image size

@mp518
4 years ago

Added screenshot new column

@mp518
4 years ago

Themes Network Admin Theme Sites.png

@mp518
4 years ago

Edit Site Network Admin Theme

@mp518
4 years ago

here is diff

@vagios
4 years ago

Merged both patches and made some fixes.

#2 @vagios
4 years ago

In 41164.1.patch I merged both patches into one. Also made some fixes,

  • Removed globals from column_screenshot documentation. (Also changed @since value)
  • Removed fixed width since it looked really bad in some cases and add some basic responsiveness to <img />. I am not sure how the screenshot should be presented but it looks as a good starting point.
  • Added alt and title attributes on <img />
  • Fixed some spacings in code.
Last edited 4 years ago by vagios (previous) (diff)

#3 @mp518
4 years ago

  • Keywords good-first-bug removed

#4 @johnbillion
4 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to johnbillion
  • Status changed from new to reviewing

#5 @kakshak
4 years ago

  • Keywords has-unit-tests added; needs-testing removed

Hello @johnbillion,
I have merged this patch in my local multi site environment and it's working fine.

@johnbillion
8 months ago

#6 @johnbillion
8 months ago

  • Keywords has-unit-tests removed
  • Milestone changed from Future Release to 5.6

41164.diff is a refreshed patch. I quite like this. Any objections?

#7 @johnbillion
7 months ago

  • Keywords needs-refresh added
  • Milestone changed from 5.6 to Future Release
  • Owner johnbillion deleted

This still needs work due to width issues on narrow viewports and the horizontal space taken up by the automatic updates column. If someone wants to pick this up and test both screens (Network Admin -> Themes and Network Admin -> Sites -> Edit -> Themes) at small resolutions and with the auto updates column in place, that would be great.

Note: See TracTickets for help on using tickets.