Opened 7 years ago
Closed 5 years ago
#41166 closed enhancement (fixed)
.htaccess config should not be shown on network setup screen when Nginx is in use
Reported by: | johnbillion | Owned by: | lipathor |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 3.0 |
Component: | Networks and Sites | Keywords: | good-first-bug has-patch needs-refresh |
Focuses: | administration, multisite | Cc: |
Description
When Nginx is in use, the .htaccess
configuration shouldn't be shown after multisite installation on the Tools -> Network Setup
screen.
It should probably be replaced with a link to the Nginx page on the Codex. Same behaviour as the Settings -> Permalinks
screen for Nginx.
Attachments (4)
Change History (15)
#1
@
7 years ago
Sometimes it's not possible to determine webserver that run our site (depend on configuration). But when $_SERVER["SERVER_SOFTWARE"]
is provided, setup prints text with link to Codex.
This ticket was mentioned in Slack in #core-multisite by greatislander. View the logs.
7 years ago
#4
@
7 years ago
- Milestone changed from Awaiting Review to Future Release
- Owner set to lipathor
- Status changed from new to assigned
Thanks for the patch @lipathor! There are only a few suggestions I'd like to make:
- I agree that a link makes more sense than inserting an nginx config file there, since that is much bigger and more complicated than the
.htaccess
snippet. I think it would be a neat improvement though if we could point the link to the relevant section on the Codex page automatically:- If a subdirectory setup is being created, append
#WordPress_Multisite_Subdirectory_rules
- If a subdomain setup is being created, append anchor
#WordPress_Multisite_subdomains_rules
- If a subdirectory setup is being created, append
- The check for whether the current setup is using nginx, can be simplified by using the
$is_nginx
global that WordPress sets up. - The location of the comment
// end iis7_supports_permalinks(). construct an htaccess file instead:
needs to be adjusted since it doesn't make sense where it's currently at.
I'm assigning this to you to mark this ticket as claimed. :)
This ticket was mentioned in Slack in #core by sergey. View the logs.
5 years ago
#8
@
5 years ago
- Keywords needs-refresh added
The patch could use a refresh for linking to HelpHub instead of Codex: https://wordpress.org/support/article/nginx/
#10
@
5 years ago
Thanks for the updated patch! Just noting the URL should be translatable and the link anchors won't be the same for translated content. Let's keep it simple and link to https://wordpress.org/support/article/nginx/, without the anchors.
Alternative text for NGINX powered sites