Identify the active theme when editing a site's themes

[johnbillion]

On the Network Admin -> Sites -> Edit -> Themes screen, the currently active theme for the site is not identified.

There should be some form of identification of the active theme.

[palmiak]

Just to be sure - you mean for example - ​http://localhost/wpmu/wp-admin/network/site-themes.php?id=xx

Of course it won't work with globally enable themes.

I attaching patch and a screenshot.

[palmiak]

Screenshot of functionality

[palmiak]

patch

[palmiak]

Patch fix

[euthelup]

Hi,

Very good proposal and I'm eager to give you a hand with it.

From a UX perspective, the "Disable" button should be visible on the active theme row?
I rather see the "Active Theme" label taking the place of the "Disable" button since atm you can disable it, but the theme remains active. Imagine the confusion when the subsite admin switches the theme and it vanishes.

[euthelup]

Replace the "Disable" button with the "Active Theme" flag when the theme is active

[euthelup]

Screenshot for the patch above

[earnjam]

The mock-up in active_theme.png​ would still allow disabling the theme using the checkbox, so it's inconsistent. You could possibly not show the checkbox for that row, but I think the label solution in e5dd8abec08ff82a087403f168726f061.png​ is the better option.

I would lean toward just adding a label to indicate the active theme, but keeping the existing disable functionality. You can already network-disable themes that are active on some sites, and there is no good way to prevent that without querying every site on the network. Not to mention if that ability was removed, it would break a common paradigm of preventing new activations of older/deprecated themes on more open-facing networks (think wordpress.com)

If we are worried about an individual site admin changing their theme after it has been disabled, then the better catch-all option would be to provide a warning when switching away from a disabled theme that you won't be able to switch back. That would cover it being disabled at the network level or per-site level.

[flixos90]

I agree with what @earnjam says.

The "Active Theme" indicator should not replace the "Disable" row action, and it also shouldn't be placed in the row actions area, since it isn't one. In addition to the above arguments, you can also disable a theme network-wide although it's enabled somewhere, so we shouldn't prevent something similar here.

For the visuals, my suggestion would be to be something similar like in the Network Users table, in the way the Super Admin user is highlighted. It's more prominent and doesn't look like it's a row action that isn't one. :)

[euthelup]

Yeah, I agree with you guys, that would be inconsistent. Now if I think about it, blocking the disable action would be a capability task, not a UI issue.

I followed @flixos90 suggestion and made a small patch inspired by the Network Users table.
The only difference is that on Network the username is a link, and the badge is bold, but I made the badge lighter in font-size since the theme name is bold.

I'm attaching a patch and a screenshot, but as a new contributor, please let me know if it is bothering when I add screenshots.

[euthelup]

Add an "Active Theme" label next to the theme name.

[euthelup]

screenshot for 41168.c.diff

[euthelup]

Extra: If marking a child theme differently than a template is a preference I've made this patch to support it.

[flixos90]

I like the way this looks. We should get some actual designer feedback though.

I'll mark this good-first-bug ticket as "claimed".

[johnbillion]

41168.diff​ tweaks this slightly so the styling is inline with other list tables (everything's within the strong tag).

[johnbillion]

In 41214:

Networks and Sites: Display an indicator for the active theme or child theme when viewing a site's themes within Network Admin.

Props palmiak, euthelup

Fixes #41168