WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#41177 closed enhancement (fixed)

Bulk site deletion doesn't present an AYS

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version: 3.0
Component: Networks and Sites Keywords: has-patch has-screenshots
Focuses: administration, multisite Cc:
PR Number:

Description

On the Network Admin -> Sites screen, bulk deleting sites doesn't present the user with an "Are you sure?" prompt.

Attachments (3)

41177.diff (2.6 KB) - added by flixos90 2 years ago.
inline-site-delete-ays.png (34.8 KB) - added by MaximeCulea 2 years ago.
Inline site delete AYS
bulk-site-delete-ays.png (47.3 KB) - added by MaximeCulea 2 years ago.
Bulk site delete AYS

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


2 years ago

@flixos90
2 years ago

#2 @flixos90
2 years ago

  • Keywords has-patch needs-testing added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.9
  • Owner set to flixos90
  • Priority changed from low to normal
  • Status changed from new to assigned

41177.diff implements a confirmation page for bulk deleting sites. The code for it is quite terrible, but just as terrible as the rest of it. I think we're long overdue looking at better practices in the admin, especially in scope of such a random ticket. I made sure to stick to our UI practices for similar confirmation pages so that at least the user gets something good out of it. :)

Last but not least, milestoning this ticket and promoting it to normal priority (I'd rather set it to "high" than "low" as it might easily cause accidental deletion of sites, which is quite critical, but "normal" should work).

@MaximeCulea
2 years ago

Inline site delete AYS

@MaximeCulea
2 years ago

Bulk site delete AYS

#3 @MaximeCulea
2 years ago

  • Keywords has-screenshots added; needs-testing removed

@flixos90 it looks good to me :

  • Functionnaly :

As expected when I delete site(s), I have an AYS redirection to confirm site(s) delete, see screenshots.

  • Patch :

I agree on the idea that when an user hasn't rights for deleting a specific site, we stop the process right away. Just want to point that remaining sites will not be deleted as wanted.

This ticket was mentioned in Slack in #core-multisite by maximeculea. View the logs.


2 years ago

#5 @johnbillion
2 years ago

  • Owner changed from flixos90 to johnbillion
  • Status changed from assigned to reviewing

This ticket was mentioned in Slack in #core-multisite by maximeculea. View the logs.


2 years ago

#7 @johnbillion
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41131:

Networks and Sites: Introduce an AYS when bulk deleting sites from the Sites screen in Network Admin.

Props flixos90, MaximeCulea

Fixes #41177

Note: See TracTickets for help on using tickets.