Bulk site deletion doesn't present an AYS

[johnbillion]

On the Network Admin -> Sites screen, bulk deleting sites doesn't present the user with an "Are you sure?" prompt.

[flixos90]

41177.diff​ implements a confirmation page for bulk deleting sites. The code for it is quite terrible, but just as terrible as the rest of it. I think we're long overdue looking at better practices in the admin, especially in scope of such a random ticket. I made sure to stick to our UI practices for similar confirmation pages so that at least the user gets something good out of it. :)

Last but not least, milestoning this ticket and promoting it to normal priority (I'd rather set it to "high" than "low" as it might easily cause accidental deletion of sites, which is quite critical, but "normal" should work).

[MaximeCulea]

Inline site delete AYS

[MaximeCulea]

Bulk site delete AYS

[MaximeCulea]

@flixos90 it looks good to me :

• Functionnaly :

As expected when I delete site(s), I have an AYS redirection to confirm site(s) delete, see screenshots.

• Patch :

I agree on the idea that when an user hasn't rights for deleting a specific site, we stop the process right away. Just want to point that remaining sites will not be deleted as wanted.

[johnbillion]

In 41131:

Networks and Sites: Introduce an AYS when bulk deleting sites from the Sites screen in Network Admin.

Props flixos90, MaximeCulea

Fixes #41177