WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4118 closed defect (bug) (fixed)

tinymce language pack loading fails if no locale is defined

Reported by: m0n5t3r Owned by:
Milestone: Priority: high
Severity: major Version: 2.1
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

If there is no locale defined, the TinyMCE language setting is empty, which leads to incorrectly generated paths for plugin language packs. The attached patch sets it to "en", which is the TinyMCE default value.

I'm marking this as major because it affects to various degrees all TinyMCE plugins that use language packs (between localization not working and meltdown - in my case it disabled the post publishing i.e. meltdown).

Attachments (2)

mce_locale_fix.diff (876 bytes) - added by m0n5t3r 7 years ago.
tiny_mce_config.php.diff (512 bytes) - added by filosofo 7 years ago.

Download all attachments as: .zip

Change History (14)

m0n5t3r7 years ago

comment:1 rob1n7 years ago

You're missing an echo.

comment:2 rob1n7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5219]) Default to 'en' for TinyMCE language if get_locale() is empty, to avoid meltdowns. Props m0n5t3r. fixes #4118 for 2.1

comment:3 rob1n7 years ago

  • Milestone changed from 2.1.4 to 2.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

now for 2.2

comment:4 rob1n7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5220]) Default to 'en' for TinyMCE language if get_locale() is empty, to avoid meltdowns. Props m0n5t3r. fixes #4118

comment:5 foolswisdom7 years ago

  • Milestone changed from 2.2 to 2.1.4
  • Version set to 2.1

comment:6 Viper007Bond7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is throwing a PHP error on my local install:

Fatal error: Can't use function return value in write context in ...\wp-includes\js\tinymce\tiny_mce_config.php on line 52

comment:7 filosofo 7 years ago

I've attached a patch that should fix that problem: I think the argument passed to empty has to be a variable.

comment:8 rob1n7 years ago

  • Milestone changed from 2.1.4 to 2.2

Well, that's retarded ;). Fixing.

comment:9 rob1n7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5224]) empty() only takes variables. Props filosofo. fixes #4118

comment:10 rob1n7 years ago

(In [5225]) empty() only takes variables. Props filosofo. fixes #4118 for 2.1

comment:11 Nazgul7 years ago

  • Milestone changed from 2.2 to 2.1.4

comment:12 anonymous7 years ago

  • Milestone 2.1.4 deleted

Milestone 2.1.4 deleted

Note: See TracTickets for help on using tickets.