WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#41192 closed defect (bug) (duplicate)

javascript comment in theme.php

Reported by: pimplaatsman's profile pimplaatsman Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords:
Focuses: javascript Cc:

Description

Hi!

Since some site minifi their HTML "" comments in javascript break functionality.
For what I know now, the only occurrence is in theme.php:3040

change request:
The customizer requires postMessage and CORS (if the site is cross domain)
To:
/* The customizer requires postMessage and CORS (if the site is cross domain) */

Regards!
Pim

Change History (2)

#1 in reply to: ↑ description @pimplaatsman
7 years ago

Sorry no double slashes, added extra space in between:
"/ / " comments in javascript break functionality.

change request:
/ / The customizer requires postMessage and CORS (if the site is cross domain)
To:
/* The customizer requires postMessage and CORS (if the site is cross domain) */

Replying to pimplaatsman:

Hi!

Since some site minifi their HTML "" comments in javascript break functionality.
For what I know now, the only occurrence is in theme.php:3040

change request:
The customizer requires postMessage and CORS (if the site is cross domain)
To:
/* The customizer requires postMessage and CORS (if the site is cross domain) */

Regards!
Pim

#2 @SergeyBiryukov
7 years ago

  • Component changed from General to Customize
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Hi @pimplaatsman, welcome to WordPress Trac!

Thanks for the report, we're already tracking this issue in #39482.

Note: See TracTickets for help on using tickets.