media-views.js: Cannot read .length of undefined (this.controller.$uploaderToggler.length)

[Blackbam]

Some change in media-views.js destroyed all my custom scripts regarding media libraries when updating WordPress to the most recent version. I do not know what $uploaderToggler is however if it is not defined the script should not stop execution.

media-views.js lines 8228 - 8242 - currently:

	show: function() {
		this.$el.removeClass( 'hidden' );
		if ( this.controller.$uploaderToggler.length ) {
			this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' );
		}
	},
	hide: function() {
		this.$el.addClass( 'hidden' );
		if ( this.controller.$uploaderToggler.length ) {
			this.controller.$uploaderToggler
				.attr( 'aria-expanded', 'false' )
				// Move focus back to the toggle button when closing the uploader.
				.focus();
		}
	}

How to fix:

	show: function() {
		this.$el.removeClass( 'hidden' );
		if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) {
			this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' );
		}
	},
	hide: function() {
		this.$el.addClass( 'hidden' );
		if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) {
			this.controller.$uploaderToggler
				.attr( 'aria-expanded', 'false' )
				// Move focus back to the toggle button when closing the uploader.
				.focus();
		}
	}

Please repair this in future versions.

[joemcgill]

Thanks @Blackbam,

Looks like this was added in [40359].

[joemcgill]

Thanks @yahil. At first glance this patch looks exactly right.

[joemcgill]

After looking more closely, this patch needed to be applied in src/wp-includes/js/media/views/uploader/inline.js since media-views.js gets autogenerated by Browserify.

41231.2.patch​ applies the change to src/wp-includes/js/media/views/uploader/inline.js as well.

[joemcgill]

In 41009:

Sanity check $uploaderToggler in wp.media.view.UploaderInline.

This ensures $uploaderToggler exists before checking length so any views
extending or scripts accessing this view, won't encounter errors that stop execution.

Props Blackbam, yahil.
Fixes #41231.

[joemcgill]

In 41010:

Sanity check $uploaderToggler in wp.media.view.UploaderInline.

This ensures $uploaderToggler exists before checking length so any views
extending or scripts accessing this view, won't encounter errors that stop execution.

See #41231.

Merges [41009] to the 4.8 branch.