Opened 8 years ago
Closed 8 years ago
#41285 closed defect (bug) (invalid)
Remove $site_id and $public multisite globals that are no longer used
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Attachments (1)
Change History (11)
This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.
8 years ago
This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.
8 years ago
This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.
8 years ago
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
8 years ago
#8
@
8 years ago
Thanks for the patch, @tejas5989!
It looks like we need to be careful with $site_id
. VaultPress is using it for something, likely in the WPCOM environment. If anyone has details on the safeness of removing that, please chime in. :)
I've poked around quite a bit and can't find anyone using $public
. I feel pretty comfortable about removing that one, but will keep digging.
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
8 years ago
#10
@
8 years ago
- Milestone 4.9 deleted
- Resolution set to invalid
- Status changed from reviewing to closed
I really want to do this, but I don't think it's worth it. There are too many unknowns out there as to how these might be used and it doesn't harm much to leave them in. I think we can document them as deprecated in #39419.
I have added patch of removing $public.