WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41286, comment 18


Ignore:
Timestamp:
03/12/2018 04:29:30 PM (3 years ago)
Author:
Joen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41286, comment 18

    initial v1  
    11I won't have time to test the patch in the near future, but based on the screenshots alone, looks good to me 👍 👍
    22
    3 Whether there's an outline-offset or not, I have not strong opinion of, up to you. Though do note that it's virtually zero effort for us to address things in Gutenberg in this phase. So if for example the buttons all look better with an outline-offset in the rest of the admin, not the editor, then we can address the outline offset in Gutenberg to match that of the buttons. Either way, let me know.
     3Whether there's an outline-offset or not, I have no strong opinion of, up to you. Though do note that it's virtually zero effort for us to address things in Gutenberg in this phase. So if for example the buttons all look better with an outline-offset in the rest of the admin, not the editor, then we can address the outline offset in Gutenberg to match that of the buttons. Either way, let me know.