WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#41288 new enhancement

wp admin bar WordPress about and updates icon can't show in Smartphone.

Reported by: mp518 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9
Component: Toolbar Keywords: has-patch has-screenshots
Focuses: ui Cc:
PR Number:

Description

WordPress admin side WordPress about and Updates can't show in smartphone it should be display none in Very narrow screens.that can be helpfully for smartphone user.

Attachments (4)

41288.patch (623 bytes) - added by mp518 2 years ago.
fix
iphone6-plus.PNG (28.7 KB) - added by mp518 2 years ago.
iphone 6 plus screen
multisite.PNG (72.1 KB) - added by mp518 2 years ago.
multisite/wp-admin screenshot
network-dashboard.PNG (66.8 KB) - added by mp518 2 years ago.
network-dashboard

Download all attachments as: .zip

Change History (13)

@mp518
2 years ago

fix

@mp518
2 years ago

iphone 6 plus screen

#1 @mp518
2 years ago

  • Keywords has-patch has-screenshots added

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#3 @afercia
2 years ago

  • Component changed from Administration to Toolbar
  • Focuses accessibility administration removed
  • Version trunk deleted

@mp518 thanks! Makes sense to check if there's enough space also on a multisite installation. :) Removing the accessibility focus since it's not strictly related to it.

#4 @mp518
2 years ago

  • Focuses accessibility added

@afercia Thanks for review.In multisite there's not available wp-admin-bar-updates icon so there's enough space i have attached screenshot which is i have merged patche on multisite.i hope it's related accessibility.

@mp518
2 years ago

multisite/wp-admin screenshot

@mp518
2 years ago

network-dashboard

#5 follow-up: @xkon
2 years ago

Hello,

@mp518 please be kind and make sure to check a max-view of 320px. People are still using ( and will be if they won't break ) older phones with smaller viewports. I'm saying this as I see your screenshots having 414px.

( I don't have a pc available atm to check the diff and test it myself sorry if that's an inconvenience ).

Just giving an extra pointer to be safe.

Best regards,
Konstantinos

Version 0, edited 2 years ago by xkon (next)

#6 follow-up: @afercia
2 years ago

  • Focuses accessibility removed

@mp518 thanks! Actually, on multisite the updates icon is available. It just gets hidden, together with the "About" one, when the viewport width is less than 600 pixels, in the same way as in a single site installation.

https://cldup.com/DuUqTzNRtb.png

Making both "About" and "Updates" always visible, and considering there are a lot of plugins that add their own icons and menus in the toolbar, can easily break the layout:

https://cldup.com/GLVMHWR3Pf.png

Please don't change the focus labels :) They're used to organize and group tickets in specific Trac reports, for example there's a report for all the accessibility tickets and this shouldn't be listed there.

#7 in reply to: ↑ 5 @mp518
2 years ago

  • Version set to trunk

yes @xkon you right but there's available media query for WordPress admin area and this media max-width 400px so hide this icon in this media(Very narrow screens) and removed media css from smart phone device as i have added in patch.
Replying to xkon:

Hello,

@mp518 please be kind and make sure to check a max-view of 320px as well. People are still using ( and will be if they won't break ) older phones with smaller viewports. I'm saying this as I see your screenshots having 414px.

( I don't have a pc available atm to check the diff and test it myself sorry if that's an inconvenience ).

Just giving an extra pointer to be safe.

Best regards,
Konstantinos

#8 in reply to: ↑ 6 @mp518
2 years ago

@afercia thanks for inform but one thing is trunk version file you don't see the wp-admin-bar-updates icon when you make a multisite and i have tested on trunk version.and wp-admin-bar-updates icon is available in single installation.

Last edited 2 years ago by mp518 (previous) (diff)

This ticket was mentioned in Slack in #core by mahesh.prajapati. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.