WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 10 months ago

#41294 closed defect (bug) (fixed)

Document $allowed_files global in get_file_description()

Reported by: div33 Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch
Focuses: docs, administration Cc:

Description

global allowed_files is used but it is not mentioned in the documentation of the get_file_description function.

Attachments (3)

41294.patch (534 bytes) - added by div33 11 months ago.
global allowed_files is used but it is not mentioned in the documentation of the get_file_description function.
41294.1.patch (611 bytes) - added by ajayghaghretiya1 11 months ago.
41294.2.patch (589 bytes) - added by div33 11 months ago.
Updated patch

Download all attachments as: .zip

Change History (9)

@div33
11 months ago

global allowed_files is used but it is not mentioned in the documentation of the get_file_description function.

#1 follow-up: @johnbillion
11 months ago

  • Keywords needs-patch added
  • Summary changed from Documnebtation needs improvement... to Documentation needs improvement...

Thanks for the patch, @div33, and welcome to WordPress Trac!

$allowed_files is a global but you've marked it as a param in your patch. Would you like to patch it again please? You can re-upload a patch with the same file name.

In addition, could you patch the file from the root directory please? This way the patch has a file name of src/wp-admin/file.php instead of just file.php.

Thanks!

#2 @ajayghaghretiya1
11 months ago

  • Keywords has-patch added; needs-patch removed

@div33
11 months ago

Updated patch

#3 in reply to: ↑ 1 @div33
11 months ago

Replying to johnbillion:

Thanks for the heads up! I've updated patch as you suggested.

Thanks again.

#4 @SergeyBiryukov
11 months ago

  • Component changed from General to Plugins
  • Focuses administration added
  • Milestone changed from Awaiting Review to 4.9

#5 @SergeyBiryukov
11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41032:

Docs: Add a @global entry for $allowed_files in get_file_description().

Props div33, ajayghaghretiya1.
Fixes #41294.

#6 @SergeyBiryukov
10 months ago

  • Summary changed from Documentation needs improvement... to Document $allowed_files global in get_file_description()
Note: See TracTickets for help on using tickets.