oEmbed proxy fails to forward maxwidth and maxheight params

[westonruter]

oEmbed uses the maxwidth and maxheight params, and the oEmbed proxy endpoint added in core as of #40450 uses the same. However, it turns out that that WP_oEmbed::fetch() uses width and height instead. So currently passing these maxwidth and maxheight params have no effect. This is causing a problem in Gutenberg where the oEmbed needs to be written into a sandbox iframe that has specific dimensions: ​https://github.com/WordPress/gutenberg/pull/1688#issuecomment-314862861

[westonruter]

​https://github.com/xwp/wordpress-develop/pull/239

[swissspidy]

Shouldn't the unset( $args['_wpnonce'] ); part be handled by #41048? Or do you want to close that one as a duplicate?

[westonruter]

@swissspidy Yes, it can be committed as part of #41048. I wasn't aware of that other ticket when I was making this patch, so I was just going to sneak it in.

[westonruter]

Refresh patch after committing fix for #41048

[westonruter]

@swissspidy does 41299.1.diff​ look good to you?

Build passes: ​https://travis-ci.org/xwp/wordpress-develop/builds/253005279

[swissspidy]

@westonruter works great!

[jnylen0]

Sorry, I just saw that you pinged me for review here. Code looks good and fixes the related Gutenberg issue mentioned in the OP. I tested as follows:

• Added the ?maxwidth= parameter in the Gutenberg code
• Loaded various embeds with and without this patch
• Before loading each embed, clear the cached results by running foreach ( $wpdb->get_results("SELECT option_name FROM $wpdb->options WHERE option_name LIKE '_transient%oembed%'") as $row ) { error_log( $row->option_name ); delete_option( $row->option_name ); } in wp shell

+1 for commit.

[westonruter]

Replying to jnylen0:

• Before loading each embed, clear the cached results by running foreach ( $wpdb->get_results("SELECT option_name FROM $wpdb->options WHERE option_name LIKE '_transient%oembed%'") as $row ) { error_log( $row->option_name ); delete_option( $row->option_name ); } in wp shell

BTW, you can also use wp transient delete --all.

[westonruter]

In 41047:

REST API: Ensure maxwidth and maxheight params are forwarded to oEmbed provider in proxy requests.

Also correct phpdoc return tag on WP_oEmbed_Controller::get_proxy_item() and remove dead code in oEmbed controller phpunit tests.

Amends [40628].
See #40450.
Fixes #41299.

[westonruter]

Re-opening for 4.8.1

[westonruter]

In 41049:

REST API: Ensure maxwidth and maxheight params are forwarded to oEmbed provider in proxy requests.

Also correct phpdoc return tag on WP_oEmbed_Controller::get_proxy_item() and remove dead code in oEmbed controller phpunit tests.

Merges [41047] into 4.8 branch.
Amends [40628].
See #40450.
Fixes #41299 for 4.8.1.