WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 8 hours ago

#41322 closed defect (bug) (fixed)

Document $default_scripts parameter in _WP_Editors::enqueue_scripts()

Reported by: ajayghaghretiya1 Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch needs-testing
Focuses: docs Cc:

Description

bool $default_scripts passed as a parameter in the function but not mention in the documentation of the function.

Attachments (5)

41322.patch (434 bytes) - added by ajayghaghretiya1 3 months ago.
added @param bool $default_scripts
41322.1.patch (451 bytes) - added by ajayghaghretiya1 3 months ago.
added @param bool $default_scripts Optional. false
41322.2 (451 bytes) - added by upadalavipul 3 months ago.
41322.3.patch (451 bytes) - added by upadalavipul 3 months ago.
41322.4.diff (497 bytes) - added by danieltj 42 hours ago.
Added new path with description and return values

Download all attachments as: .zip

Change History (11)

@ajayghaghretiya1
3 months ago

added @param bool $default_scripts

#1 follow-up: @DrewAPicture
3 months ago

  • Keywords has-patch added

Hi @ajayghaghretiya1, thanks for the patch. Can you also please add a description prefixed with "Optional." and the default of false?

@ajayghaghretiya1
3 months ago

added @param bool $default_scripts Optional. false

#2 in reply to: ↑ 1 @ajayghaghretiya1
3 months ago

Replying to DrewAPicture:

Hi @ajayghaghretiya1, thanks for the patch. Can you also please add a description prefixed with "Optional." and the default of false?

yes, I have added the new patch as you suggest. Thanks for Reviews.

Last edited 3 months ago by ajayghaghretiya1 (previous) (diff)

@upadalavipul
3 months ago

#3 @SergeyBiryukov
2 months ago

  • Summary changed from Needs improvements in the documentation of the function to Document $default_scripts parameter in _WP_Editors::enqueue_scripts()

#4 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 4.9

@danieltj
42 hours ago

Added new path with description and return values

#5 @danieltj
42 hours ago

  • Keywords needs-testing added

In 41322.4.diff

Added a refresh of the patch to include description and also a return value as well.

#6 @SergeyBiryukov
8 hours ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41917:

Docs: Document $default_scripts parameter in _WP_Editors::enqueue_scripts().

Props danieltj, ajayghaghretiya1.
Fixes #41322.

Note: See TracTickets for help on using tickets.