Bump Akismet External - 4.9 Edition

[kraftbj]

Previously #40002 and others.

Akismet 3.3.3 has been released so the external needs to bumped to:
akismet http://plugins.svn.wordpress.org/akismet/tags/3.3.3/

Once complete, the ticket can be closed and I'll reopen this one as needed for the duration of the 4.9 cycle.

This should be applied to both trunk and the 4.8 branch for points until 4.9 ships. I'll mark it with the latest 4.8.x milestone to ensure a point doesn't ship before it gets bumped.

[ocean90]

• trunk: ​https://build.trac.wordpress.org/changeset/40913
• 4.8: ​https://build.trac.wordpress.org/changeset/40914

[kraftbj]

New version out, needs a new bump:
akismet http://plugins.svn.wordpress.org/akismet/tags/3.3.4/

[sanket.parmar]

Hi @ocean90,

I have followed below steps, but I'm unable to commit using SVN ( might be the access problem ):

1. Set svn:externals property

svn propset svn:externals 'akismet http://plugins.svn.wordpress.org/akismet/tags/3.3.4/' .

2. Commit

svn ci -m "Bump Akismet external to 3.3.4" --username username --password password

But when I try to commit, I'm getting below error:

svn: E195023: Commit failed (details follow):
svn: E195023: Changing directory is forbidden by the server
svn: E175013: Access to '/!svn/me' forbidden

[ocean90]

@sanket.parmar This is only relevant for committers with access to core.svn.

---

• trunk: ​https://build.trac.wordpress.org/changeset/41168
• 4.8: ​https://build.trac.wordpress.org/changeset/41169

[kraftbj]

Akismet 4.0 is planned to be tagged today; reopening so 4.8.2 isn't surprised by it.

[kraftbj]

akismet http://plugins.svn.wordpress.org/akismet/tags/4.0/

Notably, Akismet is now using REST endpoints for settings management and stats retrieval. ​https://blog.akismet.com/akismet-wordpress-plugin-rest-api-endpoints/

[ocean90]

Since this came in on short notice we had to skip this.

[melchoyce]

@ocean90 Can we get this in for 4.9?

[ocean90]

This was done 2 weeks ago, see ​https://build.trac.wordpress.org/changeset/41431 and ​https://build.trac.wordpress.org/changeset/41432.

[kraftbj]

@melchoyce I learned today that Akismet 4.0.1 is scheduled to go out on Monday. Do we want to get it into 4.9 new packages or let is go until 4.9.1?

[melchoyce]

@kraftbj What's usually involved with Akismet bundling? Do we expect any bugs, or is it solid? RC2 won't be until the evening Pacific time, so we have some time in which to merge things on Monday. However, once we hit RC2, we're doing a soft string freeze.

[dd32]

Replying to melchoyce:

@kraftbj What's usually involved with Akismet bundling?

A committer (only a few of us though) changes the svn:external directly in core.svn.wordpress.org.

Do we expect any bugs, or is it solid?

Akismet bugs doesn't really matter for the release - although for the potential of them, it'd be better IMHO for the release to be made a few days in advance of 4.9's shipping date incase the Akismet team wishes to do a quick followup release. I say they "don't really matter" as if the release was made with 4.9.1 or in between the bugs would still exist and need fixing by the team reasonably quickly.
It's preferential that Akismet be released and shipped with a WordPress version, to avoid a new WordPress user setting up a site, and immediately having an update available ("I just downloaded the official package from WordPress.org, and I already have to perform updates?") - we don't normally rebuild releases to include an updated version of Akismet after the release (as the ZIP hash changes, etc)

RC2 won't be until the evening Pacific time, so we have some time in which to merge things on Monday. However, once we hit RC2, we're doing a soft string freeze.

Akismet strings do not end up in the core strings, they're entirely seperate. Additionally there are no code changes required - so much so, that there isn't even a commit to develop.svn.wordpress.org, only to our build svn (core.svn)

[dd32]

Bumped Akismet to 4.0.1 in trunk & the 4.8 branch (as it's the current stable branch).

Trunk: ​https://build.trac.wordpress.org/changeset/41950
4.8: ​https://build.trac.wordpress.org/changeset/41951

[melchoyce]

@dd32 Thanks! Did this make it into the 4.9 branch? We split off trunk on Monday.

[dd32]

Yep, ​https://build.trac.wordpress.org/browser/branches/4.9/wp-content/plugins shows as 4.0.1 (Hover over the "akismet" link in the svn:externals section)