WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#41327 closed task (blessed) (fixed)

Bump Akismet External - 4.9 Edition

Reported by: kraftbj Owned by: ocean90
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:
PR Number:

Description

Previously #40002 and others.

Akismet 3.3.3 has been released so the external needs to bumped to:
akismet http://plugins.svn.wordpress.org/akismet/tags/3.3.3/

Once complete, the ticket can be closed and I'll reopen this one as needed for the duration of the 4.9 cycle.

This should be applied to both trunk and the 4.8 branch for points until 4.9 ships. I'll mark it with the latest 4.8.x milestone to ensure a point doesn't ship before it gets bumped.

Change History (17)

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#4 @kraftbj
2 years ago

  • Milestone changed from 4.8.1 to 4.8.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

New version out, needs a new bump:
akismet http://plugins.svn.wordpress.org/akismet/tags/3.3.4/

#5 @sanket.parmar
2 years ago

Hi @ocean90,

I have followed below steps, but I'm unable to commit using SVN ( might be the access problem ):

  1. Set svn:externals property
svn propset svn:externals 'akismet http://plugins.svn.wordpress.org/akismet/tags/3.3.4/' .
  1. Commit
svn ci -m "Bump Akismet external to 3.3.4" --username username --password password

But when I try to commit, I'm getting below error:

svn: E195023: Commit failed (details follow):
svn: E195023: Changing directory is forbidden by the server
svn: E175013: Access to '/!svn/me' forbidden

#6 @ocean90
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

@sanket.parmar This is only relevant for committers with access to core.svn.


#7 @kraftbj
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Akismet 4.0 is planned to be tagged today; reopening so 4.8.2 isn't surprised by it.

This ticket was mentioned in Slack in #core by kraft. View the logs.


2 years ago

#9 @kraftbj
2 years ago

  • Owner set to ocean90
  • Status changed from reopened to assigned

akismet http://plugins.svn.wordpress.org/akismet/tags/4.0/

Notably, Akismet is now using REST endpoints for settings management and stats retrieval. https://blog.akismet.com/akismet-wordpress-plugin-rest-api-endpoints/

#10 @ocean90
2 years ago

  • Milestone changed from 4.8.2 to 4.9

Since this came in on short notice we had to skip this.

#11 @melchoyce
2 years ago

@ocean90 Can we get this in for 4.9?

#12 @ocean90
2 years ago

  • Milestone changed from 4.9 to WordPress.org
  • Resolution set to fixed
  • Status changed from assigned to closed

#13 @kraftbj
2 years ago

@melchoyce I learned today that Akismet 4.0.1 is scheduled to go out on Monday. Do we want to get it into 4.9 new packages or let is go until 4.9.1?

#14 follow-up: @melchoyce
2 years ago

@kraftbj What's usually involved with Akismet bundling? Do we expect any bugs, or is it solid? RC2 won't be until the evening Pacific time, so we have some time in which to merge things on Monday. However, once we hit RC2, we're doing a soft string freeze.

#15 in reply to: ↑ 14 @dd32
2 years ago

Replying to melchoyce:

@kraftbj What's usually involved with Akismet bundling?

A committer (only a few of us though) changes the svn:external directly in core.svn.wordpress.org.

Do we expect any bugs, or is it solid?

Akismet bugs doesn't really matter for the release - although for the potential of them, it'd be better IMHO for the release to be made a few days in advance of 4.9's shipping date incase the Akismet team wishes to do a quick followup release. I say they "don't really matter" as if the release was made with 4.9.1 or in between the bugs would still exist and need fixing by the team reasonably quickly.
It's preferential that Akismet be released and shipped with a WordPress version, to avoid a new WordPress user setting up a site, and immediately having an update available ("I just downloaded the official package from WordPress.org, and I already have to perform updates?") - we don't normally rebuild releases to include an updated version of Akismet after the release (as the ZIP hash changes, etc)

RC2 won't be until the evening Pacific time, so we have some time in which to merge things on Monday. However, once we hit RC2, we're doing a soft string freeze.

Akismet strings do not end up in the core strings, they're entirely seperate. Additionally there are no code changes required - so much so, that there isn't even a commit to develop.svn.wordpress.org, only to our build svn (core.svn)

#16 @dd32
2 years ago

  • Milestone changed from WordPress.org to 4.9

Bumped Akismet to 4.0.1 in trunk & the 4.8 branch (as it's the current stable branch).

Trunk: https://build.trac.wordpress.org/changeset/41950
4.8: https://build.trac.wordpress.org/changeset/41951

#17 @melchoyce
2 years ago

@dd32 Thanks! Did this make it into the 4.9 branch? We split off trunk on Monday.

#18 @dd32
2 years ago

Yep, https://build.trac.wordpress.org/browser/branches/4.9/wp-content/plugins shows as 4.0.1 (Hover over the "akismet" link in the svn:externals section)

Note: See TracTickets for help on using tickets.